PageDecorator and global.jelly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

PageDecorator and global.jelly

John Siirola
Devs,

I have been fighting what appears to be a "simple" problem using the
PageDecorator extension point...  I have a plugin that implements an
extension of the PageDecorator to provide administrators with
free-form boxes in the site configuration for specifying site-wide
headers/footers.  The weird bug that I am hitting is that it appears
that Hudson is instantiating two instances of the extension:  one is
connected to the PageDecorator extension point, and the other is used
by the "Configure System" page (for handling the global.jelly config).
 The net effect is that any changes that a user makes through the web
UI requires a restart of all of Hudson before the changes become
visible.

This also appears to affect other plugins like Google Analytics.

Is this a bug, or am I missing something obvious?  My current
workaround is to have the extension register itself with a static
registry so that the instanced that handles the configuration can
trigger the instance actually hooked to the extension point to re-load
itself.

Thanks,
john

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: PageDecorator and global.jelly

Kohsuke Kawaguchi-3

I looked at the goolgle-analytics plugin source code. If this plugin
ends up getting two instances, it sounds like a bug.

Digging bit deeper...

On 09/23/2010 02:51 PM, John Siirola wrote:

> Devs,
>
> I have been fighting what appears to be a "simple" problem using the
> PageDecorator extension point...  I have a plugin that implements an
> extension of the PageDecorator to provide administrators with
> free-form boxes in the site configuration for specifying site-wide
> headers/footers.  The weird bug that I am hitting is that it appears
> that Hudson is instantiating two instances of the extension:  one is
> connected to the PageDecorator extension point, and the other is used
> by the "Configure System" page (for handling the global.jelly config).
>   The net effect is that any changes that a user makes through the web
> UI requires a restart of all of Hudson before the changes become
> visible.
>
> This also appears to affect other plugins like Google Analytics.
>
> Is this a bug, or am I missing something obvious?  My current
> workaround is to have the extension register itself with a static
> registry so that the instanced that handles the configuration can
> trigger the instance actually hooked to the extension point to re-load
> itself.
>
> Thanks,
> john
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Kohsuke Kawaguchi | InfraDNA, Inc. | http://infradna.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: PageDecorator and global.jelly

Kohsuke Kawaguchi-3

Fixed toward upcoming 1.379.

On 09/29/2010 06:41 PM, Kohsuke Kawaguchi wrote:

>
> I looked at the goolgle-analytics plugin source code. If this plugin
> ends up getting two instances, it sounds like a bug.
>
> Digging bit deeper...
>
> On 09/23/2010 02:51 PM, John Siirola wrote:
>>  Devs,
>>
>>  I have been fighting what appears to be a "simple" problem using the
>>  PageDecorator extension point...  I have a plugin that implements an
>>  extension of the PageDecorator to provide administrators with
>>  free-form boxes in the site configuration for specifying site-wide
>>  headers/footers.  The weird bug that I am hitting is that it appears
>>  that Hudson is instantiating two instances of the extension:  one is
>>  connected to the PageDecorator extension point, and the other is used
>>  by the "Configure System" page (for handling the global.jelly config).
>>    The net effect is that any changes that a user makes through the web
>>  UI requires a restart of all of Hudson before the changes become
>>  visible.
>>
>>  This also appears to affect other plugins like Google Analytics.
>>
>>  Is this a bug, or am I missing something obvious?  My current
>>  workaround is to have the extension register itself with a static
>>  registry so that the instanced that handles the configuration can
>>  trigger the instance actually hooked to the extension point to re-load
>>  itself.
>>
>>  Thanks,
>>  john
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: [hidden email]
>>  For additional commands, e-mail: [hidden email]
>>
>>
>
>


--
Kohsuke Kawaguchi | InfraDNA, Inc. | http://infradna.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]