Patch for form validation error in Subversion plugin when a revision is specified

[Christoph Kutzinski]

Hi,

the subversion plugin allows to specify a revision to checkout from - e.g.
svn://server/trunk@123 or svn://server/trunk@HEAD.
However, the form validation in the job config page displays an error like:
'Invalid url svn://server/trunk@HEAD Did you mean svn://server/trunk?'

I've attached a patch which fixes this problem.
The patch also adds validation for the revision.

Could someone please have a look on it and - if it's okay - either
commit it or let me know, so I can commit it myself?


thanks
Christoph

[Christoph Kutzinski]

This time with patch :)

Am 15.01.2011 20:42, schrieb Christoph Kutzinski:

> Hi,
>
> the subversion plugin allows to specify a revision to checkout from -
> e.g.
> svn://server/trunk@123 or svn://server/trunk@HEAD.
> However, the form validation in the job config page displays an error
> like:
> 'Invalid url svn://server/trunk@HEAD Did you mean svn://server/trunk?'
>
> I've attached a patch which fixes this problem.
> The patch also adds validation for the revision.
>
> Could someone please have a look on it and - if it's okay - either
> commit it or let me know, so I can commit it myself?
>
>
> thanks
> Christoph

[Alan Harder-2]

Go ahead and commit.. 2 minor comments:
- I noticed minor indent/tab/space issues in the patch file..
- Looks like it checks proper revision before proper URL.. would a string
like "a@b" complain about the revision rather than the URL?  Maybe consider
switching the order of checks?

     - Alan

> This time with patch :)
>
> Am 15.01.2011 20:42, schrieb Christoph Kutzinski:
>> Hi,
>>
>> the subversion plugin allows to specify a revision to checkout from - e.g.
>> svn://server/trunk@123 or svn://server/trunk@HEAD.
>> However, the form validation in the job config page displays an error like:
>> 'Invalid url svn://server/trunk@HEAD Did you mean svn://server/trunk?'
>>
>> I've attached a patch which fixes this problem.
>> The patch also adds validation for the revision.
>>
>> Could someone please have a look on it and - if it's okay - either
>> commit it or let me know, so I can commit it myself?
>>
>>
>> thanks
>> Christoph
>

[Christoph Kutzinski]

Thanks for the review.

In can fix the tab/space/indent issues, but I wonder what the official style for Hudson is? Space or tab? If space, how many spaces to indent?


Christoph

-------- Original-Nachricht --------
> Datum: Sun, 16 Jan 2011 17:01:23 -0800
> Von: Alan Harder <[hidden email]>
> An: [hidden email]
> Betreff: Re: Patch for form validation error in Subversion plugin when a revision is specified

> Go ahead and commit.. 2 minor comments:
> - I noticed minor indent/tab/space issues in the patch file..
> - Looks like it checks proper revision before proper URL.. would a string
> like "a@b" complain about the revision rather than the URL?  Maybe
> consider
> switching the order of checks?
>
>      - Alan
>
>
> > This time with patch :)
> >
> > Am 15.01.2011 20:42, schrieb Christoph Kutzinski:
> >> Hi,
> >>
> >> the subversion plugin allows to specify a revision to checkout from -
> e.g.
> >> svn://server/trunk@123 or svn://server/trunk@HEAD.
> >> However, the form validation in the job config page displays an error
> like:
> >> 'Invalid url svn://server/trunk@HEAD Did you mean svn://server/trunk?'
> >>
> >> I've attached a patch which fixes this problem.
> >> The patch also adds validation for the revision.
> >>
> >> Could someone please have a look on it and - if it's okay - either
> >> commit it or let me know, so I can commit it myself?
> >>
> >>
> >> thanks
> >> Christoph
> >

[Dean Yu]

There’s no “official style” other than to be consistent with the rest of the file, but the convention in the majority of the source code seems to be spaces with four spaces per indent.

  -- Dean


On 1/17/11 1:00 AM, "Christoph Kutzinski" <kutzi@...> wrote:

Thanks for the review.

In can fix the tab/space/indent issues, but I wonder what the official style for Hudson is? Space or tab? If space, how many spaces to indent?


Christoph

-------- Original-Nachricht --------
> Datum: Sun, 16 Jan 2011 17:01:23 -0800
> Von: Alan Harder <mindless@...>
> An: hudson-dev@...
> Betreff: Re: Patch for form validation error in Subversion plugin when a revision is specified

> Go ahead and commit.. 2 minor comments:
> - I noticed minor indent/tab/space issues in the patch file..
> - Looks like it checks proper revision before proper URL.. would a string
> like "a@b" complain about the revision rather than the URL?  Maybe
> consider
> switching the order of checks?
>
>      - Alan
>
>
> > This time with patch :)
> >
> > Am 15.01.2011 20:42, schrieb Christoph Kutzinski:
> >> Hi,
> >>
> >> the subversion plugin allows to specify a revision to checkout from -
> e.g.
> >> svn://server/trunk@123 or svn://server/trunk@HEAD.
> >> However, the form validation in the job config page displays an error
> like:
> >> 'Invalid url svn://server/trunk@HEAD Did you mean svn://server/trunk?'
> >>
> >> I've attached a patch which fixes this problem.
> >> The patch also adds validation for the revision.
> >>
> >> Could someone please have a look on it and - if it's okay - either
> >> commit it or let me know, so I can commit it myself?
> >>
> >>
> >> thanks
> >> Christoph
> >