Patch for issue #788 (zipping empty directories)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for issue #788 (zipping empty directories)

Daniel Dyer-2
I've just submitted a patch for issue #788 (exception when zipping empty  
directories).  I've changed it so that it doesn't display the zip link and  
instead shows some text that says "No files in directory".

See https://hudson.dev.java.net/issues/show_bug.cgi?id=788.

Is this the best/preferred way to submit patches or should they be mailed  
to one of the lists?

Thanks,

Dan.

--
Daniel Dyer
https://watchmaker.dev.java.net - Evolutionary Computation for Java

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Patch for issue #788 (zipping empty directories)

Kohsuke Kawaguchi
Administrator
Daniel Dyer wrote:
> I've just submitted a patch for issue #788 (exception when zipping empty  
> directories).  I've changed it so that it doesn't display the zip link and  
> instead shows some text that says "No files in directory".
>
> See https://hudson.dev.java.net/issues/show_bug.cgi?id=788.
>
> Is this the best/preferred way to submit patches or should they be mailed  
> to one of the lists?

Thanks. I applied the changes for 1.154. Patches in the issue tracker is
better, I think.

I gave the commit access to you, so for this kind of small changes, feel
free to just commit a change. I'm monitoring the commit messages and I
can complain if I see something that I didn't like.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment