Plugin adoption request: NUnit

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Plugin adoption request: NUnit

Shin-ichi Morita
Hi Team,

I would like to adopt NUnit plugin and request commit access.

My current interest is fixing JENKINS-50162. I submitted this pull request about 20 days ago without noticing it is marked for adoption.

* Link to a plugin you want to adopt: https://github.com/jenkinsci/nunit-plugin
* Link(s) to pull requests you want to deliver: https://github.com/jenkinsci/nunit-plugin/pull/23
* Your GitHub username/id: s-morita-being
* Your Jenkins infrastructure account id: smorita

Thank you in advance,

Shin-ichi Morita

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/87c58adf-c70d-4fbf-ba89-d8e3ff71fccdo%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Plugin adoption request: NUnit

Oleg Nenashev
+1 from me, it would be great to have a new maintainer in this plugin.
Thanks a lot for stepping up!

I have also pinged the code reviewers team, let's see whether we could get some reviews.

BR, Oleg

On Friday, June 12, 2020 at 5:07:06 PM UTC+2, Shin-ichi Morita wrote:
Hi Team,

I would like to adopt NUnit plugin and request commit access.

My current interest is fixing JENKINS-50162. I submitted this pull request about 20 days ago without noticing it is marked for adoption.

* Link to a plugin you want to adopt: <a href="https://github.com/jenkinsci/nunit-plugin" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fnunit-plugin\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEZkqicubczJP7cx0XS6GEsZteC7w&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fnunit-plugin\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEZkqicubczJP7cx0XS6GEsZteC7w&#39;;return true;">https://github.com/jenkinsci/nunit-plugin
* Link(s) to pull requests you want to deliver: <a href="https://github.com/jenkinsci/nunit-plugin/pull/23" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fnunit-plugin%2Fpull%2F23\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHOC9yRnUwHtsMCoQJP9a5SGr1Fvw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fnunit-plugin%2Fpull%2F23\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHOC9yRnUwHtsMCoQJP9a5SGr1Fvw&#39;;return true;">https://github.com/jenkinsci/nunit-plugin/pull/23
* Your GitHub username/id: s-morita-being
* Your Jenkins infrastructure account id: smorita

Thank you in advance,

Shin-ichi Morita

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4ca0f8f6-77dd-4c22-b93b-180c20b3afb7o%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Plugin adoption request: NUnit

Shin-ichi Morita
Thank you for the quick response.

On Saturday, June 13, 2020 at 6:20:51 AM UTC+9, Oleg Nenashev wrote:
+1 from me, it would be great to have a new maintainer in this plugin.
Thanks a lot for stepping up!

I have also pinged the code reviewers team, let's see whether we could get some reviews.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7ac22a82-7b43-4b9a-bffb-43204fb224fbo%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Plugin adoption request: NUnit

Oleg Nenashev
Hi,

First of all, thanks a lot for the pull request! It looks good to me, and hopefully it will fix the issue for the users.
Since the plugin is officially marked for adoption and there was no negative votes, I went ahead and granted the release permissions.


Welcome aboard!

Best regards,
Oleg

On Monday, June 15, 2020 at 1:48:35 AM UTC+2, Shin-ichi Morita wrote:
Thank you for the quick response.

On Saturday, June 13, 2020 at 6:20:51 AM UTC+9, Oleg Nenashev wrote:
+1 from me, it would be great to have a new maintainer in this plugin.
Thanks a lot for stepping up!

I have also pinged the code reviewers team, let's see whether we could get some reviews.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ac616f8d-5df2-43f7-a614-99aeb58bededo%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Plugin adoption request: NUnit

Shin-ichi Morita
Hi Oleg,

Thank you for the review and the instruction.

I have sent a pull request for release permissions: https://github.com/jenkins-infra/repository-permissions-updater/pull/1579

Best regards,
Shin-ichi Morita


On Wednesday, June 17, 2020 at 4:25:05 AM UTC+9, Oleg Nenashev wrote:
Hi,

First of all, thanks a lot for the pull request! It looks good to me, and hopefully it will fix the issue for the users.
Since the plugin is officially marked for adoption and there was no negative votes, I went ahead and granted the release permissions.

To get release permissions, you will need to send a pull request to <a href="https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-nunit.yml" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkins-infra%2Frepository-permissions-updater%2Fblob%2Fmaster%2Fpermissions%2Fplugin-nunit.yml\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGASsPRcbgFPK4GF2doWgBcJ_sUmA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkins-infra%2Frepository-permissions-updater%2Fblob%2Fmaster%2Fpermissions%2Fplugin-nunit.yml\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGASsPRcbgFPK4GF2doWgBcJ_sUmA&#39;;return true;">https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-nunit.yml

Welcome aboard!

Best regards,
Oleg

On Monday, June 15, 2020 at 1:48:35 AM UTC+2, Shin-ichi Morita wrote:
Thank you for the quick response.

On Saturday, June 13, 2020 at 6:20:51 AM UTC+9, Oleg Nenashev wrote:
+1 from me, it would be great to have a new maintainer in this plugin.
Thanks a lot for stepping up!

I have also pinged the code reviewers team, let's see whether we could get some reviews.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b26528b0-ee0e-4052-85fb-47cc6dabc6a3o%40googlegroups.com.