Proposal: Jenkins Core PR reviewers team

classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Proposal: Jenkins Core PR reviewers team

Oleg Nenashev
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Marky Jackson
+1 from me

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "<a href="tel:+1%20(408)%20464%202965" dir="ltr" x-apple-data-detectors="true" x-apple-data-detectors-type="telephone" x-apple-data-detectors-result="0">+1 (408) 464 2965”,
         "email" : “[hidden email]",
         "team" : “jackson5“,
 “role” : “software engineer"
     }
 }

On Sep 19, 2019, at 4:26 AM, Oleg Nenashev <[hidden email]> wrote:

Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/681846C1-89AD-423E-BD7D-E9F171A8DFB7%40gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Tim Jacomb
In reply to this post by Oleg Nenashev
Sounds good to me

On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev <[hidden email]> wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Mark Waite-2
I like the idea very much.  GitHub triage looks like a really nice addition without granting more permissions than necessary.

On Thu, Sep 19, 2019 at 5:58 AM Tim Jacomb <[hidden email]> wrote:
Sounds good to me

On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev <[hidden email]> wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com.


--
Thanks!
Mark Waite

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHVQq%2BdciSsHU0w5jVhrJ%3DYemzUqeERV7-6sCRYASfyuQ%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Matt Sicker
I like this idea, too.

On Thu, Sep 19, 2019 at 7:09 AM Mark Waite <[hidden email]> wrote:

>
> I like the idea very much.  GitHub triage looks like a really nice addition without granting more permissions than necessary.
>
> On Thu, Sep 19, 2019 at 5:58 AM Tim Jacomb <[hidden email]> wrote:
>>
>> Sounds good to me
>>
>> On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev <[hidden email]> wrote:
>>>
>>> Hi all,
>>>
>>> I would like to make a proposal w.r.t the Jenkins Core review process.
>>>
>>> As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.
>>>
>>> Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).
>>>
>>> What I suggest to do:
>>>
>>> Introduce a new jenkinsci/core-pr-reviewers team
>>> Grant the team TRIAGE permission in  https://github.com/jenkinsci/jenkins
>>> Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
>>> Invite contributors who regularly review Jenkins core pull requests: alecharp, varyvol, MarkEWaite, res0nance, jvz, MRamonLeon, halkeye (sorry if I missed anyone!)
>>>
>>> If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).
>>>
>>> What do you think?
>>>
>>> Best regards,
>>> Oleg
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
>>> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.
>>
>> --
>> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
>> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com.
>
>
>
> --
> Thanks!
> Mark Waite
>
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHVQq%2BdciSsHU0w5jVhrJ%3DYemzUqeERV7-6sCRYASfyuQ%40mail.gmail.com.



--
Matt Sicker
Senior Software Engineer, CloudBees

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4oy%2BOUkozcYzErMpUqexxexX9OMx6aYRKaiFzCQcd5dJ9Q%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Daniel Beck
In reply to this post by Oleg Nenashev
+1

> On 19. Sep 2019, at 13:26, Oleg Nenashev <[hidden email]> wrote:
>
> Hi all,
>
> I would like to make a proposal w.r.t the Jenkins Core review process.
>
> As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.
>
> Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).
>
> What I suggest to do:
> • Introduce a new jenkinsci/core-pr-reviewers team
> • Grant the team TRIAGE permission in  https://github.com/jenkinsci/jenkins
> • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
> • Invite contributors who regularly review Jenkins core pull requests: alecharp, varyvol, MarkEWaite, res0nance, jvz, MRamonLeon, halkeye (sorry if I missed anyone!)
> If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).
>
> What do you think?
>
> Best regards,
> Oleg
>
>
>
>
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/DC096577-39A9-42BC-A1ED-6CBFE8885BC5%40beckweb.net.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Oleg Nenashev
Looks like we have a consensus here. I will proceed with the change tomorrow if no negative feedback

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a5fe6214-7fb5-44a2-8ec2-9b53c6dd629c%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Baptiste MATHUS
+1 great idea, and feature indeed.
Thanks a lot Oleg

Le jeu. 19 sept. 2019 à 23:14, Oleg Nenashev <[hidden email]> a écrit :
Looks like we have a consensus here. I will proceed with the change tomorrow if no negative feedback

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a5fe6214-7fb5-44a2-8ec2-9b53c6dd629c%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6evN%2BH74BZiq%2BEK%3DReL8R1RVx4AX6qVGzG8syMHX5kew%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Tim Jacomb
In reply to this post by Oleg Nenashev
I would be interested in joining this team

On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the <a href="https://github.com/jenkinsci/jenkins/pulls" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;">pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new <a href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;">TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
  • Introduce a new jenkinsci/core-pr-reviewers team
  • Grant the team TRIAGE permission in  <a href="https://github.com/jenkinsci/jenkins" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;">https://github.com/jenkinsci/jenkins
  • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
  • Invite contributors who regularly review Jenkins core pull requests: <a href="https://github.com/alecharp" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;">alecharp, <a href="https://github.com/varyvol" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;">varyvol, <a href="https://github.com/MarkEWaite" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;">MarkEWaite, <a href="https://github.com/res0nance" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;">res0nance, <a href="https://github.com/jvz" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;">jvz, <a href="http://MRamonLeon" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;">MRamonLeon, <a href="https://github.com/halkeye" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;">halkeye (sorry if I missed anyone!)
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1458d898-d647-47b1-8d03-3021d361eef8%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Oleg Nenashev
Thanks to all for the feedback!
I have created the team: https://github.com/orgs/jenkinsci/teams/core-pr-reviewers
Please let me know if it works for you.

Best regards,
Oleg


On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote:
I would be interested in joining this team

On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the <a href="https://github.com/jenkinsci/jenkins/pulls" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;">pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new <a href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;">TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
  • Introduce a new jenkinsci/core-pr-reviewers team
  • Grant the team TRIAGE permission in  <a href="https://github.com/jenkinsci/jenkins" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;">https://github.com/jenkinsci/jenkins
  • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
  • Invite contributors who regularly review Jenkins core pull requests: <a href="https://github.com/alecharp" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;">alecharp, <a href="https://github.com/varyvol" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;">varyvol, <a href="https://github.com/MarkEWaite" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;">MarkEWaite, <a href="https://github.com/res0nance" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;">res0nance, <a href="https://github.com/jvz" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;">jvz, <a href="http://MRamonLeon" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;">MRamonLeon, <a href="https://github.com/halkeye" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;">halkeye (sorry if I missed anyone!)
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4ab8d12a-b90f-4a45-99b2-d0d5ce89de85%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Raihaan Shouhell
In reply to this post by Oleg Nenashev
I'd be keen on this +1

On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the <a href="https://github.com/jenkinsci/jenkins/pulls" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;">pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new <a href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;">TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
  • Introduce a new jenkinsci/core-pr-reviewers team
  • Grant the team TRIAGE permission in  <a href="https://github.com/jenkinsci/jenkins" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;">https://github.com/jenkinsci/jenkins
  • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
  • Invite contributors who regularly review Jenkins core pull requests: <a href="https://github.com/alecharp" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;">alecharp, <a href="https://github.com/varyvol" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;">varyvol, <a href="https://github.com/MarkEWaite" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;">MarkEWaite, <a href="https://github.com/res0nance" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;">res0nance, <a href="https://github.com/jvz" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;">jvz, <a href="http://MRamonLeon" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;">MRamonLeon, <a href="https://github.com/halkeye" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;">halkeye (sorry if I missed anyone!)
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Olblak-2
\o/

---
-> gpg --keyserver keys.gnupg.net --recv-key 52210D3D
---




On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote:
I'd be keen on this +1

On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg








--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

halkeye
Doesnt look like I'm on the team afterall

I think this is a great idea.

I'm taking night school so I don't know how much I can help, but I will at least be up.gor helping reviewing during hacktober at the very least.

Gavin

On Fri., Sep. 20, 2019, 2:56 a.m. Olblak, <[hidden email]> wrote:
\o/

---
-> gpg --keyserver keys.gnupg.net --recv-key 52210D3D
---




On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote:
I'd be keen on this +1

On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg








--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duv-mpC_5F%2B5eoW3r2jvg5yO0VPiOh2zudLRq%2BN742AkPA%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Oleg Nenashev
Thanks Raihaan and Gavin!

I did not add people to the group without explicit consent, but I have added you taking the feedback here.
So we have officially added 9 more reviewers to the Core, and it at least doubles our review capacity there.
Thanks all!

P.S: We also have https://github.com/orgs/jenkinsci/teams/code-reviewers/ for general review pings and https://github.com/orgs/jenkinsci/teams/hacktoberfest/ for the Hacktoberfest reviews.
If someone is interested, please feel free to send a join request to these teams.

Best regards,
Oleg

On Friday, September 20, 2019 at 9:27:25 PM UTC+2, Gavin Mogan wrote:
Doesnt look like I'm on the team afterall

I think this is a great idea.

I'm taking night school so I don't know how much I can help, but I will at least be up.gor helping reviewing during hacktober at the very least.

Gavin

On Fri., Sep. 20, 2019, 2:56 a.m. Olblak, <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="VoZm517QAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">m...@...> wrote:
\o/

---
-> gpg --keyserver <a href="http://keys.gnupg.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fkeys.gnupg.net\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGGvem0n8cSWWfyOfhzR-uVSpk4NQ&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fkeys.gnupg.net\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGGvem0n8cSWWfyOfhzR-uVSpk4NQ&#39;;return true;">keys.gnupg.net --recv-key 52210D3D
---




On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote:
I'd be keen on this +1

On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the <a rel="nofollow" href="https://github.com/jenkinsci/jenkins/pulls" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;">pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new <a rel="nofollow" href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;">TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
  • Introduce a new jenkinsci/core-pr-reviewers team
  • Grant the team TRIAGE permission in  <a rel="nofollow" href="https://github.com/jenkinsci/jenkins" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;">https://github.com/jenkinsci/jenkins
  • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
  • Invite contributors who regularly review Jenkins core pull requests: <a rel="nofollow" href="https://github.com/alecharp" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;">alecharp, <a rel="nofollow" href="https://github.com/varyvol" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;">varyvol, <a rel="nofollow" href="https://github.com/MarkEWaite" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;">MarkEWaite, <a rel="nofollow" href="https://github.com/res0nance" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;">res0nance, <a rel="nofollow" href="https://github.com/jvz" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;">jvz, <a rel="nofollow" href="http://MRamonLeon" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;">MRamonLeon, <a rel="nofollow" href="https://github.com/halkeye" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;">halkeye (sorry if I missed anyone!)
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg








--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="VoZm517QAQAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="VoZm517QAQAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/85e026ee-fb54-47b5-83a5-354035e6f8d5%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Marky Jackson
In reply to this post by Oleg Nenashev
Hello all!
I would like to be added to this team if possible.

On Friday, September 20, 2019 at 2:03:17 AM UTC-7, Oleg Nenashev wrote:
Thanks to all for the feedback!
I have created the team: <a href="https://github.com/orgs/jenkinsci/teams/core-pr-reviewers" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Forgs%2Fjenkinsci%2Fteams%2Fcore-pr-reviewers\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZd4s5gHvAa_4SlCQCwl6LCMsdTw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Forgs%2Fjenkinsci%2Fteams%2Fcore-pr-reviewers\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZd4s5gHvAa_4SlCQCwl6LCMsdTw&#39;;return true;">https://github.com/orgs/jenkinsci/teams/core-pr-reviewers
Please let me know if it works for you.

Best regards,
Oleg


On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote:
I would be interested in joining this team

On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the <a href="https://github.com/jenkinsci/jenkins/pulls" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;">pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new <a href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;">TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
  • Introduce a new jenkinsci/core-pr-reviewers team
  • Grant the team TRIAGE permission in  <a href="https://github.com/jenkinsci/jenkins" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;">https://github.com/jenkinsci/jenkins
  • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
  • Invite contributors who regularly review Jenkins core pull requests: <a href="https://github.com/alecharp" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;">alecharp, <a href="https://github.com/varyvol" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;">varyvol, <a href="https://github.com/MarkEWaite" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;">MarkEWaite, <a href="https://github.com/res0nance" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;">res0nance, <a href="https://github.com/jvz" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;">jvz, <a href="http://MRamonLeon" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;">MRamonLeon, <a href="https://github.com/halkeye" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;">halkeye (sorry if I missed anyone!)
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/cebb15af-35ec-41f6-929d-c2cc8c5a73d0%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Oleg Nenashev
Hi Marky,

Thanks for the interest! I am definitely +1 taking all your contributions in other areas.
One potential concern is that you have not contributed much to the Jenkins core yet, and for a reviewer.it would be useful to have some experience with the review process from another side.
We do not have it in the requirements defined above, would be nice to hear what others say about it.

BR, Oleg

On Sunday, February 2, 2020 at 1:18:32 AM UTC+1, Marky Jackson wrote:
Hello all!
I would like to be added to this team if possible.

On Friday, September 20, 2019 at 2:03:17 AM UTC-7, Oleg Nenashev wrote:
Thanks to all for the feedback!
I have created the team: <a href="https://github.com/orgs/jenkinsci/teams/core-pr-reviewers" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Forgs%2Fjenkinsci%2Fteams%2Fcore-pr-reviewers\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZd4s5gHvAa_4SlCQCwl6LCMsdTw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Forgs%2Fjenkinsci%2Fteams%2Fcore-pr-reviewers\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGZd4s5gHvAa_4SlCQCwl6LCMsdTw&#39;;return true;">https://github.com/orgs/jenkinsci/teams/core-pr-reviewers
Please let me know if it works for you.

Best regards,
Oleg


On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote:
I would be interested in joining this team

On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the <a href="https://github.com/jenkinsci/jenkins/pulls" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins%2Fpulls\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF0FrU6lTzwjKc7Ha_hgQspAjGSlg&#39;;return true;">pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new <a href="https://help.github.com/en/articles/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fhelp.github.com%2Fen%2Farticles%2Frepository-permission-levels-for-an-organization%23permission-levels-for-repositories-owned-by-an-organization\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGl67eVtrpxMEHOOa-MC_kA6GJuQw&#39;;return true;">TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:
  • Introduce a new jenkinsci/core-pr-reviewers team
  • Grant the team TRIAGE permission in  <a href="https://github.com/jenkinsci/jenkins" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjenkins\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEv3_qzLj4opXocKH1RUvhR-97kZA&#39;;return true;">https://github.com/jenkinsci/jenkins
  • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
  • Invite contributors who regularly review Jenkins core pull requests: <a href="https://github.com/alecharp" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Falecharp\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFME9fpRi0fK5R-G8OIVV6l9Gjoew&#39;;return true;">alecharp, <a href="https://github.com/varyvol" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fvaryvol\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGCcstErF2zzVpl_Po6SjWH0h3d6A&#39;;return true;">varyvol, <a href="https://github.com/MarkEWaite" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FMarkEWaite\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGqcOCMdYDZ2IPkqXK7yNbJA9Eckw&#39;;return true;">MarkEWaite, <a href="https://github.com/res0nance" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fres0nance\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFITkwbrq-pRt4gZKD8i9FkPLwR2A&#39;;return true;">res0nance, <a href="https://github.com/jvz" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjvz\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHPme269H0E6Ia_VPAUUOjoN-oX5g&#39;;return true;">jvz, <a href="http://MRamonLeon" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2FMRamonLeon\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGo71LdY-E8xykGF2iyKPklG2LX7A&#39;;return true;">MRamonLeon, <a href="https://github.com/halkeye" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fhalkeye\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFYodN-3uaae9JOMv65jWAes_TkUQ&#39;;return true;">halkeye (sorry if I missed anyone!)
If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,
Oleg







--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4295a166-e94b-4fc3-b941-9e7b163f81f3%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Daniel Beck-2
Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Marky Jackson
I love a good challenge.
Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.
Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <[hidden email]> wrote:


Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Gavin Mogan
Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly elsewhere.

(this leaves room for Marky though)

On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson <[hidden email]> wrote:
I love a good challenge.
Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.
Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <[hidden email]> wrote:


Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Proposal: Jenkins Core PR reviewers team

Marky Jackson
I am happy to be included and thank you Gavin

On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <[hidden email]> wrote:

Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly elsewhere.

(this leaves room for Marky though)

On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson <[hidden email]> wrote:
I love a good challenge.
Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.
Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <[hidden email]> wrote:


Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.


--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/04BD050C-4C95-4A65-AC85-38D2119D99EE%40gmail.com.
12