RE: cloned project triggers build before edit and save, instead of afterwards

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RE: cloned project triggers build before edit and save, instead of afterwards

Adam Purkiss
(moved to dev list for implementation discussion).
 
A quick look and if I am understanding things correctly Job handles the copying, where as project has the property for disabled build. I dont have any time to delve deeper now but does anyone know how you can set a project variable from a job? I would assume that maybe its on of the properties but I dont have time to run in debug mode to check my theory and figure out which one to change.
 
thanks




 


From: [hidden email]
To: [hidden email]
Date: Tue, 22 Jul 2008 10:00:24 -0400
Subject: RE: cloned project triggers build before edit and save, instead of afterwards

Thinking on it the cloning is something I have done a lot and the auto build has irked me. Another little thing that maybe I can look into... just need to find where in the code cloning is done....






> Date: Tue, 22 Jul 2008 15:57:44 +0200

> From: [hidden email]
> To: [hidden email]
> Subject: Re: cloned project triggers build before edit and save, instead of afterwards
>
> On Tue, Jul 22, 2008 at 3:40 PM, Adam Purkiss <[hidden email]> wrote:
> > Maybe by default it should clone it and be disabled. The used then has to
> > enable the project as a confirmation step that the job is set correctly?
>
> +1, sounds like a good plan.
>
> //Erik
>
> >
> >
> >
> > ________________________________
> > Date: Tue, 22 Jul 2008 10:44:27 +0100
> > From: [hidden email]
> > To: [hidden email]
> > Subject: Re: cloned project triggers build before edit and save, instead of
> > afterwards
> >
> > You have clones the polling....
> >
> > And the polling kicks in...
> >
> > The workaround is to disable the project you are cloning, clone it, and
> > re-enabled the project you are cloning. Then you configure the clone and
> > lastly enable it.
> >
> > On Tue, Jul 22, 2008 at 9:00 AM, Lloyd Chang <[hidden email]> wrote:
> >
> > Hi Kohsuke and all,
> >
> > It seems a little odd that "create new project from existing one"
> > seems to "clone the existing project, give it a new name, fire off a
> > build, then present the configuration options so we can edit them".
> > Shouldn't it really be "clone the existing project, give it a new
> > name, present the configuration options, and then wait for the trigger
> > or manual build request" ???
> >
> > In other words, when we clone foo to bar, the new "bar" project
> > immediately starts a build of the cloned (foo) parameters. Now that
> > we know this, we can clone, then quickly edit, then (hopefully)
> > quickly kill the current build-in-progress, and start a new build
> > manually.
> >
> > A colleague asked me to pass above onto you. If you have an
> > explanation for the current behavior, I would like to know why. If I
> > should file a bug to change the workflow (per our suggestion) to
> > trigger a build after the edit and save, please let me know.
> >
> > Thanks,
> > Lloyd
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
> >
> > ________________________________
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>






Reply | Threaded
Open this post in threaded view
|

RE: cloned project triggers build before edit and save, instead of afterwards

Adam Purkiss
I have attached a patch that deals with disabling the copied build. It looks to be working.
 
On a side not the current checked in code for hudson throws a js error on the config screen.
 
master is null
 var table = master.parentNode;
 
 
 




 


From: [hidden email]
To: [hidden email]
Date: Tue, 22 Jul 2008 10:29:48 -0400
Subject: RE: cloned project triggers build before edit and save, instead of afterwards

(moved to dev list for implementation discussion).
 
A quick look and if I am understanding things correctly Job handles the copying, where as project has the property for disabled build. I dont have any time to delve deeper now but does anyone know how you can set a project variable from a job? I would assume that maybe its on of the properties but I dont have time to run in debug mode to check my theory and figure out which one to change.
 
thanks




 




From: [hidden email]
To: [hidden email]
Date: Tue, 22 Jul 2008 10:00:24 -0400
Subject: RE: cloned project triggers build before edit and save, instead of afterwards

Thinking on it the cloning is something I have done a lot and the auto build has irked me. Another little thing that maybe I can look into... just need to find where in the code cloning is done....








> Date: Tue, 22 Jul 2008 15:57:44 +0200
> From: [hidden email]
> To: [hidden email]
> Subject: Re: cloned project triggers build before edit and save, instead of afterwards
>
> On Tue, Jul 22, 2008 at 3:40 PM, Adam Purkiss <[hidden email]> wrote:
> > Maybe by default it should clone it and be disabled. The used then has to
> > enable the project as a confirmation step that the job is set correctly?
>
> +1, sounds like a good plan.
>
> //Erik
>
> >
> >
> >
> > ________________________________
> > Date: Tue, 22 Jul 2008 10:44:27 +0100
> > From: [hidden email]
> > To: [hidden email]
> > Subject: Re: cloned project triggers build before edit and save, instead of
> > afterwards
> >
> > You have clones the polling....
> >
> > And the polling kicks in...
> >
> > The workaround is to disable the project you are cloning, clone it, and
> > re-enabled the project you are cloning. Then you configure the clone and
> > lastly enable it.
> >
> > On Tue, Jul 22, 2008 at 9:00 AM, Lloyd Chang <[hidden email]> wrote:
> >
> > Hi Kohsuke and all,
> >
> > It seems a little odd that "create new project from existing one"
> > seems to "clone the existing project, give it a new name, fire off a
> > build, then present the configuration options so we can edit them".
> > Shouldn't it really be "clone the existing project, give it a new
> > name, present the configuration options, and then wait for the trigger
> > or manual build request" ???
> >
> > In other words, when we clone foo to bar, the new "bar" project
> > immediately starts a build of the cloned (foo) parameters. Now that
> > we know this, we can clone, then quickly edit, then (hopefully)
> > quickly kill the current build-in-progress, and start a new build
> > manually.
> >
> > A colleague asked me to pass above onto you. If you have an
> > explanation for the current behavior, I would like to know why. If I
> > should file a bug to change the workflow (per our suggestion) to
> > trigger a build after the edit and save, please let me know.
> >
> > Thanks,
> > Lloyd
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
> >
> > ________________________________
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>













---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

projectCopy.patch (886 bytes) Download Attachment