Re: GitHub and Bitbucket branch source UI refactoring

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Kevin Burnett
we'd be down to try that, yes. thanks for making these changes in a way that will benefit the product long-term!

fingers are crossed that there's already a built-in way to pretend like pull requests don't exist! you're already building the branches; why also build the pull requests, eh? :)

thanks!
kb


On Friday, June 16, 2017 at 2:35:54 PM UTC-4, Mark Waite wrote:
I'd like to be part of the beta test.

Mark Waite

On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="JOz9_opVAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">stephen.al...@gmail.com> wrote:
Just a quick status update.

In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source

I am finalising the GitHub Branch Source changes... likely to be another big PR

Then there's a 5k LoC change in the Git plugin

Plan is to try and get all merged next week and cut a beta

I'll be looking for people to help test at that stage.

Please respond if you think you can help (lots of bugs fixed as a side effect of the refactoring - it makes things more easy to test => I found and fixed bugs)
--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="JOz9_opVAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/fd613b68-3f87-4650-a3f9-6657d8f4179a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Michael Kobit

I may be able to help with this as well.


On Fri, Jun 16, 2017, 17:28 Dan Tran <[hidden email]> wrote:
I will give it a spin too.

Thanks

-Dan

On Friday, June 16, 2017 at 11:57:26 AM UTC-7, Kevin Burnett wrote:
we'd be down to try that, yes. thanks for making these changes in a way that will benefit the product long-term!

fingers are crossed that there's already a built-in way to pretend like pull requests don't exist! you're already building the branches; why also build the pull requests, eh? :)

thanks!
kb


On Friday, June 16, 2017 at 2:35:54 PM UTC-4, Mark Waite wrote:
I'd like to be part of the beta test.

Mark Waite

On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly <[hidden email]> wrote:
Just a quick status update.

In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source

I am finalising the GitHub Branch Source changes... likely to be another big PR

Then there's a 5k LoC change in the Git plugin

Plan is to try and get all merged next week and cut a beta

I'll be looking for people to help test at that stage.

Please respond if you think you can help (lots of bugs fixed as a side effect of the refactoring - it makes things more easy to test => I found and fixed bugs)
--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/5dd15ac2-b8a2-4ebd-bb4a-3bffa4815227%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9GHbX4WuHdDKM8-bU1xR5voh-NsfHeQXNAxMjJpXkiwrw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Michael Kobit

Will be able to run this through tomorrow or Friday. The before state is harder to get because of how we manage onboarding consumers.


On Wed, Jun 21, 2017, 13:39 Mark Waite <[hidden email]> wrote:
I haven't tried it yet.  I'm configuring the "before" state today and will capture its state, then will deploy the new code tomorrow morning and capture the after state.  I won't do anything to compare those until tomorrow evening or this weekend.

Mark Waite

On Wed, Jun 21, 2017 at 12:30 PM Stephen Connolly <[hidden email]> wrote:
How many people have been able to try this so far?

On Tue 20 Jun 2017 at 14:52, Stephen Connolly <[hidden email]> wrote:
If you are chomping at the bit, here are all the binaries:


SHA1 checksums:
d9c346ac8db497a35825c7dbbb934842a2bc429a  branch-api.hpi
16da429f09fb585fd1d744809ee22c8d612fb62c  cloudbees-bitbucket-branch-source.hpi
234fa8eb88dad3241d620bb0116dd12fb9decbba  git.hpi
a68be01144f3045f81a5cf3c0bc60ad12f39b643  github-branch-source.hpi
92237097815b45260bb8b272caa9be9f92eb5085  mercurial.hpi
04c321420b3752a8d8b3af89cae1bf5934607b1c  scm-api.hpi

SHA256 checksums:
858ce20992c3f179b850c512979999084b11fe7c4c173cf6d4d2e07bbfebf3e7  branch-api.hpi
8ebff7a3ec43df276d4b51d1e5bcb910bbe8eb4cd47a4be0e35f2f2ca1cd0e03  cloudbees-bitbucket-branch-source.hpi
46cbbf11395df4a085829094d5a36dee7328aeba00d33e34b44aa0dcf9898248  git.hpi
6495a60f1bf0733d807f412434c6c2e24b7bba53fd7ce348ca5319ef38571f20  github-branch-source.hpi
173d12042fe8582efdb52e740f4e939b9daa05f181c6aaff31824337d519a31c  mercurial.hpi
9b58e9e6d13ce90a91b73f38142bf0977f244df9c52b948988f9d5bdc3785481  scm-api.hpi

-Stephen

On 20 June 2017 at 14:29, Stephen Connolly <[hidden email]> wrote:
OK! Here we are... testing time!

These are the plugins that are being covered: (download links should be live in an hour or two)


Recommended testing procedure:

1. Set up a throw-away Jenkins running a version similar to your production environment with the pre-upgrade versions of the plugins you are using.
2. Set up ideally at least one organization folder and one standalone multibranch project building your source code - to a first order you do not care if the builds succeed or fail, only that the branches are found.
3. Trigger a scan / index of your organization folders and standalone multibranch projects.
4. Wait for the queue to complete
5. Run the script in the system script console: https://gist.github.com/stephenc/64ef58783b4438a126ad4e3f43062df1 and save the output to smoke-pre-upgrade.txt
6. Upgrade the relevant plugins, restart Jenkins.
7. Run the script in the system script console: https://gist.github.com/stephenc/64ef58783b4438a126ad4e3f43062df1 and save the output to smoke-post-upgrade.txt
8. Trigger a scan / index of your organization folders and standalone multibranch projects.
9. Wait for the queue to complete
10. Run the script in the system script console: https://gist.github.com/stephenc/64ef58783b4438a126ad4e3f43062df1 and save the output to smoke-post-rescan.txt

At this point, do a diff between smoke-pre-upgrade.txt and smoke-post-rescan.txt

You are looking for three classes of difference:

a. branch jobs that have been rebuilt for no reason (i.e. the revision is the same)
b. branch jobs that have disappeared for no good reason (i.e. the branch is still present in the backing scm)
c. branch jobs that have suddenly appeared for no good reason (i.e. the branch was there before but not found) [expecting some of these for BitBucket PRs from forks, but only after configuration updated, saved and another rescan performed]

My expectation is that nobody will have these kinds of issues.

Also try out the new UI to see what you think.

Please report back your testing results either way. Don't forget to report back your UI feedback too ;-)

After doing that test in a throw-away Jenkins, you can *optionally* repeat the test on a more production-like (emphasis on being production-like not production) instance... but this is code that has not yet completed code review (hence -alpha-1 not -beta-1) so it is at your own risk. There are additional issues to be aware when using more production-like environment:

a. You may have builds that were assuming branches were full clones, now the refspec is tightly reduced to minimize clone time. If you need a full clone you will need to add the "Advanced Clone" behaviour.
b. Mercurial repositories on Bitbucket Cloud do not support merge commits for PR building (yet)
c. Credential domains were not being correctly compared so as a result - if you are using credential domains to help sort credentials - there may be cases where the credentials are now searched for in a different domain than you had them in, so your domains may need reconfiguration to have the credentials found by the multibranch project / org folder.
d. The pipeline snippitizer is generating $class style for some of the GitHub and BitBucket specific behaviours, this is because my plan is to further consolidate the implementations and have a single shared implementation of each for these plugins, that way they can have a single @Symbol annotation... if that is too difficult then the @Symbol would need to be prefixed with gitHub / bitbucket respectively, e.g. gitHubBranches, bitbucketBranches for the discover branches behaviour.


Thanks in advance

-Stephen

On 18 June 2017 at 15:53, Michael Kobit <[hidden email]> wrote:

I may be able to help with this as well.


On Fri, Jun 16, 2017, 17:28 Dan Tran <[hidden email]> wrote:
I will give it a spin too.

Thanks

-Dan

On Friday, June 16, 2017 at 11:57:26 AM UTC-7, Kevin Burnett wrote:
we'd be down to try that, yes. thanks for making these changes in a way that will benefit the product long-term!

fingers are crossed that there's already a built-in way to pretend like pull requests don't exist! you're already building the branches; why also build the pull requests, eh? :)

thanks!
kb


On Friday, June 16, 2017 at 2:35:54 PM UTC-4, Mark Waite wrote:
I'd like to be part of the beta test.

Mark Waite

On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly <[hidden email]> wrote:
Just a quick status update.

In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source

I am finalising the GitHub Branch Source changes... likely to be another big PR

Then there's a 5k LoC change in the Git plugin

Plan is to try and get all merged next week and cut a beta

I'll be looking for people to help test at that stage.

Please respond if you think you can help (lots of bugs fixed as a side effect of the refactoring - it makes things more easy to test => I found and fixed bugs)
--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/5dd15ac2-b8a2-4ebd-bb4a-3bffa4815227%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9GHbX4WuHdDKM8-bU1xR5voh-NsfHeQXNAxMjJpXkiwrw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMz1NimOSn1UYZyjwZ4KFEiDFoHf6L9Wy7Q3vyDb6959-Q%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CAO49JtEmZC_dde2yyEHpGEY3e_V4rY2tqO2NXhyO0YZDytDipw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9G%3Df6Wpn8%2BGKcp3DtqRFpG4%3DMYqg%3D0Ca4wBDqPi1WzPtQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

stephenconnolly
If you cannot get an ideal "before" that's ok... I'm just trying to make it easier to know if you have and problematic rebuilds... if you can't get it clean, best is better than none at all

On Wed 21 Jun 2017 at 20:34, Michael Kobit <[hidden email]> wrote:

Will be able to run this through tomorrow or Friday. The before state is harder to get because of how we manage onboarding consumers.


On Wed, Jun 21, 2017, 13:39 Mark Waite <[hidden email]> wrote:
I haven't tried it yet.  I'm configuring the "before" state today and will capture its state, then will deploy the new code tomorrow morning and capture the after state.  I won't do anything to compare those until tomorrow evening or this weekend.

Mark Waite

On Wed, Jun 21, 2017 at 12:30 PM Stephen Connolly <[hidden email]> wrote:
How many people have been able to try this so far?

On Tue 20 Jun 2017 at 14:52, Stephen Connolly <[hidden email]> wrote:
If you are chomping at the bit, here are all the binaries:


SHA1 checksums:
d9c346ac8db497a35825c7dbbb934842a2bc429a  branch-api.hpi
16da429f09fb585fd1d744809ee22c8d612fb62c  cloudbees-bitbucket-branch-source.hpi
234fa8eb88dad3241d620bb0116dd12fb9decbba  git.hpi
a68be01144f3045f81a5cf3c0bc60ad12f39b643  github-branch-source.hpi
92237097815b45260bb8b272caa9be9f92eb5085  mercurial.hpi
04c321420b3752a8d8b3af89cae1bf5934607b1c  scm-api.hpi

SHA256 checksums:
858ce20992c3f179b850c512979999084b11fe7c4c173cf6d4d2e07bbfebf3e7  branch-api.hpi
8ebff7a3ec43df276d4b51d1e5bcb910bbe8eb4cd47a4be0e35f2f2ca1cd0e03  cloudbees-bitbucket-branch-source.hpi
46cbbf11395df4a085829094d5a36dee7328aeba00d33e34b44aa0dcf9898248  git.hpi
6495a60f1bf0733d807f412434c6c2e24b7bba53fd7ce348ca5319ef38571f20  github-branch-source.hpi
173d12042fe8582efdb52e740f4e939b9daa05f181c6aaff31824337d519a31c  mercurial.hpi
9b58e9e6d13ce90a91b73f38142bf0977f244df9c52b948988f9d5bdc3785481  scm-api.hpi

-Stephen

On 20 June 2017 at 14:29, Stephen Connolly <[hidden email]> wrote:
OK! Here we are... testing time!

These are the plugins that are being covered: (download links should be live in an hour or two)


Recommended testing procedure:

1. Set up a throw-away Jenkins running a version similar to your production environment with the pre-upgrade versions of the plugins you are using.
2. Set up ideally at least one organization folder and one standalone multibranch project building your source code - to a first order you do not care if the builds succeed or fail, only that the branches are found.
3. Trigger a scan / index of your organization folders and standalone multibranch projects.
4. Wait for the queue to complete
5. Run the script in the system script console: https://gist.github.com/stephenc/64ef58783b4438a126ad4e3f43062df1 and save the output to smoke-pre-upgrade.txt
6. Upgrade the relevant plugins, restart Jenkins.
7. Run the script in the system script console: https://gist.github.com/stephenc/64ef58783b4438a126ad4e3f43062df1 and save the output to smoke-post-upgrade.txt
8. Trigger a scan / index of your organization folders and standalone multibranch projects.
9. Wait for the queue to complete
10. Run the script in the system script console: https://gist.github.com/stephenc/64ef58783b4438a126ad4e3f43062df1 and save the output to smoke-post-rescan.txt

At this point, do a diff between smoke-pre-upgrade.txt and smoke-post-rescan.txt

You are looking for three classes of difference:

a. branch jobs that have been rebuilt for no reason (i.e. the revision is the same)
b. branch jobs that have disappeared for no good reason (i.e. the branch is still present in the backing scm)
c. branch jobs that have suddenly appeared for no good reason (i.e. the branch was there before but not found) [expecting some of these for BitBucket PRs from forks, but only after configuration updated, saved and another rescan performed]

My expectation is that nobody will have these kinds of issues.

Also try out the new UI to see what you think.

Please report back your testing results either way. Don't forget to report back your UI feedback too ;-)

After doing that test in a throw-away Jenkins, you can *optionally* repeat the test on a more production-like (emphasis on being production-like not production) instance... but this is code that has not yet completed code review (hence -alpha-1 not -beta-1) so it is at your own risk. There are additional issues to be aware when using more production-like environment:

a. You may have builds that were assuming branches were full clones, now the refspec is tightly reduced to minimize clone time. If you need a full clone you will need to add the "Advanced Clone" behaviour.
b. Mercurial repositories on Bitbucket Cloud do not support merge commits for PR building (yet)
c. Credential domains were not being correctly compared so as a result - if you are using credential domains to help sort credentials - there may be cases where the credentials are now searched for in a different domain than you had them in, so your domains may need reconfiguration to have the credentials found by the multibranch project / org folder.
d. The pipeline snippitizer is generating $class style for some of the GitHub and BitBucket specific behaviours, this is because my plan is to further consolidate the implementations and have a single shared implementation of each for these plugins, that way they can have a single @Symbol annotation... if that is too difficult then the @Symbol would need to be prefixed with gitHub / bitbucket respectively, e.g. gitHubBranches, bitbucketBranches for the discover branches behaviour.


Thanks in advance

-Stephen

On 18 June 2017 at 15:53, Michael Kobit <[hidden email]> wrote:

I may be able to help with this as well.


On Fri, Jun 16, 2017, 17:28 Dan Tran <[hidden email]> wrote:
I will give it a spin too.

Thanks

-Dan

On Friday, June 16, 2017 at 11:57:26 AM UTC-7, Kevin Burnett wrote:
we'd be down to try that, yes. thanks for making these changes in a way that will benefit the product long-term!

fingers are crossed that there's already a built-in way to pretend like pull requests don't exist! you're already building the branches; why also build the pull requests, eh? :)

thanks!
kb


On Friday, June 16, 2017 at 2:35:54 PM UTC-4, Mark Waite wrote:
I'd like to be part of the beta test.

Mark Waite

On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly <[hidden email]> wrote:
Just a quick status update.

In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source

I am finalising the GitHub Branch Source changes... likely to be another big PR

Then there's a 5k LoC change in the Git plugin

Plan is to try and get all merged next week and cut a beta

I'll be looking for people to help test at that stage.

Please respond if you think you can help (lots of bugs fixed as a side effect of the refactoring - it makes things more easy to test => I found and fixed bugs)
--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/5dd15ac2-b8a2-4ebd-bb4a-3bffa4815227%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9GHbX4WuHdDKM8-bU1xR5voh-NsfHeQXNAxMjJpXkiwrw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.


--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMz1NimOSn1UYZyjwZ4KFEiDFoHf6L9Wy7Q3vyDb6959-Q%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9G%3Df6Wpn8%2BGKcp3DtqRFpG4%3DMYqg%3D0Ca4wBDqPi1WzPtQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CA%2BnPnMwyX20pMOyK8hb8M2hdaZamM2RWZUuaj0uXFkURZnmDhg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Mark Waite-2
In reply to this post by Kevin Burnett
My docker image that I've upgraded is showing an unexpected behavior in a GitHub (not git) 

On Friday, June 16, 2017 at 12:19:24 PM UTC-6, Stephen Connolly wrote:
Just a quick status update.

In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source

I am finalising the GitHub Branch Source changes... likely to be another big PR

Then there's a 5k LoC change in the Git plugin

Plan is to try and get all merged next week and cut a beta

I'll be looking for people to help test at that stage.

Please respond if you think you can help (lots of bugs fixed as a side effect of the refactoring - it makes things more easy to test => I found and fixed bugs)
--
Sent from my phone

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/642d0696-e348-4924-85cd-49f69b6d8658%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Kevin Burnett
In reply to this post by Michael Kobit
This is so good. :)

The pre and post diffs looked right, and the new UI and functionality gives me everything that I was hoping for.

I'm going to remove the "discover pull requests from [everywhere]" behaviors and select "Only branches that are also filed as PRs" on production as soon as possible.

Michael Neale mentioned that one issue he had seen "does look better now with the new version." I used the plugin versions that Stephen originally posted on June 20, but I take Michael's comment to mean there might be newer versions. Please make this irrelevant by issuing release versions of these plugins this week. :)

Thanks a ton!
-KB

On Friday, June 23, 2017 at 12:45:44 PM UTC-4, Stephen Connolly wrote:


On 23 June 2017 at 17:24, Mark Waite <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="v3_4rCMeAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">mark.ea...@...> wrote:
I see duplicate entries in the "Add' configuration of the Bitbucket source for "Checkout over ssh".  Let me know if you need steps to see that.

Shouldn't... may just be a bug in the drop down populator when you have GitHub and Bitbucket
 

I also wonder if the text "General", "Git" and "Bitbucket" should be italicized, or bold, or separated with dashes, or something, so that the user has a concept that things will be appearing under them.  They seem to be standard text currently, and it wasn't obvious to me that they were categories into which settings would be placed.

Cannot style the drop-down menu without significant JS changes that risk affecting form binding.
 

Mark Waite


On Friday, June 23, 2017 at 9:58:52 AM UTC-6, Mark Waite wrote:
The UI experience has been great for me in the two or three places where I've used it.  I was a little surprised (and pleased) with the adaptation that the local branch setting is now a toggle.  I think that's the right approach, since (as far as I can tell) that is the 99% use case.

Earlier I reported an NPE when configuring a multi-branch pipeline that uses GitHub as source instead of Git as source.  The NPE was resolved by removing the multiple-scms plugin.  Unfortunately, the 404 is still there, along with a stack trace that starts with this:

Jun 23, 2017 9:51:38 AM hudson.ExpressionFactory2$JexlExpression evaluate
WARNING: Caught exception evaluating: descriptor.calcFillSettings(field,attrs) in /job/Git-Client-Folder/job/git-client-pipeline-github/configure. Reason: java.lang.IllegalStateException: class org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl doesn't have the doFillCredentialsIdItems method for filling a drop-down list
java.lang.IllegalStateException: class org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl doesn't have the doFillCredentialsIdItems method for filling a drop-down list
at hudson.model.Descriptor.calcFillSettings(Descriptor.java:412)
at sun.reflect.GeneratedMethodAccessor578.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.commons.jexl.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:258)
at org.apache.commons.jexl.parser.ASTMethod.execute(ASTMethod.java:104)
at org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83)
at org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57)
at org.apache.commons.jexl.parser.ASTReferenceExpression.value(ASTReferenceExpression.java:51)
at org.apache.commons.jexl.ExpressionImpl.evaluate(ExpressionImpl.java:80)
at hudson.ExpressionFactory2$JexlExpression.evaluate(ExpressionFactory2.java:74)
at org.apache.commons.jelly.parser.EscapingExpression.evaluate(EscapingExpression.java:24)
at org.apache.commons.jelly.impl.ExpressionScript.run(ExpressionScript.java:66)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)

I'm not sure how to provide a repeatable condition for that bug yet, but wanted to alert you about it.  I won't investigate further on it until after the end of the working day today.

Mark Waite

On Friday, June 23, 2017 at 7:32:54 AM UTC-6, Stephen Connolly wrote:
How do you find the new UI compared with the previous one?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="v3_4rCMeAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/2bc996a5-b2d6-4c22-884a-a7a026cc9472%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Michael Kobit

I'm going to have time to do this today. Are there newer alphas available?


On Mon, Jun 26, 2017, 08:13 Kevin Burnett <[hidden email]> wrote:
This is so good. :)

The pre and post diffs looked right, and the new UI and functionality gives me everything that I was hoping for.

I'm going to remove the "discover pull requests from [everywhere]" behaviors and select "Only branches that are also filed as PRs" on production as soon as possible.

Michael Neale mentioned that one issue he had seen "does look better now with the new version." I used the plugin versions that Stephen originally posted on June 20, but I take Michael's comment to mean there might be newer versions. Please make this irrelevant by issuing release versions of these plugins this week. :)

Thanks a ton!
-KB

On Friday, June 23, 2017 at 12:45:44 PM UTC-4, Stephen Connolly wrote:


On 23 June 2017 at 17:24, Mark Waite <[hidden email]> wrote:
I see duplicate entries in the "Add' configuration of the Bitbucket source for "Checkout over ssh".  Let me know if you need steps to see that.

Shouldn't... may just be a bug in the drop down populator when you have GitHub and Bitbucket
 

I also wonder if the text "General", "Git" and "Bitbucket" should be italicized, or bold, or separated with dashes, or something, so that the user has a concept that things will be appearing under them.  They seem to be standard text currently, and it wasn't obvious to me that they were categories into which settings would be placed.

Cannot style the drop-down menu without significant JS changes that risk affecting form binding.
 

Mark Waite


On Friday, June 23, 2017 at 9:58:52 AM UTC-6, Mark Waite wrote:
The UI experience has been great for me in the two or three places where I've used it.  I was a little surprised (and pleased) with the adaptation that the local branch setting is now a toggle.  I think that's the right approach, since (as far as I can tell) that is the 99% use case.

Earlier I reported an NPE when configuring a multi-branch pipeline that uses GitHub as source instead of Git as source.  The NPE was resolved by removing the multiple-scms plugin.  Unfortunately, the 404 is still there, along with a stack trace that starts with this:

Jun 23, 2017 9:51:38 AM hudson.ExpressionFactory2$JexlExpression evaluate
WARNING: Caught exception evaluating: descriptor.calcFillSettings(field,attrs) in /job/Git-Client-Folder/job/git-client-pipeline-github/configure. Reason: java.lang.IllegalStateException: class org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl doesn't have the doFillCredentialsIdItems method for filling a drop-down list
java.lang.IllegalStateException: class org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl doesn't have the doFillCredentialsIdItems method for filling a drop-down list
at hudson.model.Descriptor.calcFillSettings(Descriptor.java:412)
at sun.reflect.GeneratedMethodAccessor578.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.commons.jexl.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:258)
at org.apache.commons.jexl.parser.ASTMethod.execute(ASTMethod.java:104)
at org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83)
at org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57)
at org.apache.commons.jexl.parser.ASTReferenceExpression.value(ASTReferenceExpression.java:51)
at org.apache.commons.jexl.ExpressionImpl.evaluate(ExpressionImpl.java:80)
at hudson.ExpressionFactory2$JexlExpression.evaluate(ExpressionFactory2.java:74)
at org.apache.commons.jelly.parser.EscapingExpression.evaluate(EscapingExpression.java:24)
at org.apache.commons.jelly.impl.ExpressionScript.run(ExpressionScript.java:66)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)

I'm not sure how to provide a repeatable condition for that bug yet, but wanted to alert you about it.  I won't investigate further on it until after the end of the working day today.

Mark Waite

On Friday, June 23, 2017 at 7:32:54 AM UTC-6, Stephen Connolly wrote:
How do you find the new UI compared with the previous one?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/2bc996a5-b2d6-4c22-884a-a7a026cc9472%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9FMzPhsq2YPKSgnMZaz14bkVM1fnahFJoZt4ytkWPj5zQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: GitHub and Bitbucket branch source UI refactoring

Michael Kobit
In reply to this post by Kevin Burnett
Finally got some time to try it out (sorry!) and I know the PR has already been merged, but UI looks great, and the contextual help menus make it easy to pick up. Awesome job!

Only thing I noticed is no built-in Job DSL support - we use the Job DSL entirely to create and setup all of our Organization folders, and I didn't see any generated DSL methods under /plugin/job-dsl/api-viewer/index.html#path/organizationFolder-organizations-bitbucket.

On Thu, Jun 29, 2017 at 9:43 AM Mark Waite <[hidden email]> wrote:
I think I have detected the difference between by multi-branch pipelines with GitHub branch sources.

The problem job is a GitHub private repository (https://github.com/MarkEWaite/jenkins-bugs-private), while the working job is a GitHub public repository (https://github.com/MarkEWaite/jenkins-bugs) .

When I configure the private repository job, it presents the list of repositories but only includes public repositories in the list.  The credentials are valid and are used in other jobs, but it is as though the list of repositories is not being refreshed with the credentials.

Mark Waite

On Thu, Jun 29, 2017 at 8:27 AM Mark Waite <[hidden email]> wrote:
I'm using latest betas (as far as I can tell).  The GitHub source is now working in the cases that were failing previously.  Thanks very much for that!

Unfortunately, when I open the "Configure" page for one of my multi-branch pipeline job that is using GitHub as a branch source, it reverts the repository choice to the top of the list, instead of showing the originally selected repository.

When I open the "Configure" page for another of my multi-branch pipeline jobs that is using GitHub as a branch source, it retains the repository choice.

Unfortunately, I don't know what is different between those two cases of a GitHub branch source for a multi-branch pipeline.

I'll let you know if I identify key attributes which make the two cases behave differently.

Mark Waite 


On Monday, June 26, 2017 at 10:04:00 PM UTC-6, Michael Neale wrote:
I retested with latest betas and looking good (binary compat, migration etc). 

On Monday, June 26, 2017 at 11:46:49 PM UTC+10, Stephen Connolly wrote:


On 26 June 2017 at 06:13, Kevin Burnett <[hidden email]> wrote:
This is so good. :)

Great to hear it. I love feedback (+ve or -ve beats none)
 

The pre and post diffs looked right, and the new UI and functionality gives me everything that I was hoping for.

w00t
 

I'm going to remove the "discover pull requests from [everywhere]" behaviors and select "Only branches that are also filed as PRs" on production as soon as possible.

Michael Neale mentioned that one issue he had seen "does look better now with the new version." I used the plugin versions that Stephen originally posted on June 20, but I take Michael's comment to mean there might be newer versions. Please make this irrelevant by issuing release versions of these plugins this week. :)

Thanks a ton!
-KB

On Friday, June 23, 2017 at 12:45:44 PM UTC-4, Stephen Connolly wrote:


On 23 June 2017 at 17:24, Mark Waite <[hidden email]> wrote:
I see duplicate entries in the "Add' configuration of the Bitbucket source for "Checkout over ssh".  Let me know if you need steps to see that.

Shouldn't... may just be a bug in the drop down populator when you have GitHub and Bitbucket
 

I also wonder if the text "General", "Git" and "Bitbucket" should be italicized, or bold, or separated with dashes, or something, so that the user has a concept that things will be appearing under them.  They seem to be standard text currently, and it wasn't obvious to me that they were categories into which settings would be placed.

Cannot style the drop-down menu without significant JS changes that risk affecting form binding.
 

Mark Waite


On Friday, June 23, 2017 at 9:58:52 AM UTC-6, Mark Waite wrote:
The UI experience has been great for me in the two or three places where I've used it.  I was a little surprised (and pleased) with the adaptation that the local branch setting is now a toggle.  I think that's the right approach, since (as far as I can tell) that is the 99% use case.

Earlier I reported an NPE when configuring a multi-branch pipeline that uses GitHub as source instead of Git as source.  The NPE was resolved by removing the multiple-scms plugin.  Unfortunately, the 404 is still there, along with a stack trace that starts with this:

Jun 23, 2017 9:51:38 AM hudson.ExpressionFactory2$JexlExpression evaluate
WARNING: Caught exception evaluating: descriptor.calcFillSettings(field,attrs) in /job/Git-Client-Folder/job/git-client-pipeline-github/configure. Reason: java.lang.IllegalStateException: class org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl doesn't have the doFillCredentialsIdItems method for filling a drop-down list
java.lang.IllegalStateException: class org.jenkinsci.plugins.github_branch_source.GitHubSCMSource$DescriptorImpl doesn't have the doFillCredentialsIdItems method for filling a drop-down list
at hudson.model.Descriptor.calcFillSettings(Descriptor.java:412)
at sun.reflect.GeneratedMethodAccessor578.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.commons.jexl.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:258)
at org.apache.commons.jexl.parser.ASTMethod.execute(ASTMethod.java:104)
at org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83)
at org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57)
at org.apache.commons.jexl.parser.ASTReferenceExpression.value(ASTReferenceExpression.java:51)
at org.apache.commons.jexl.ExpressionImpl.evaluate(ExpressionImpl.java:80)
at hudson.ExpressionFactory2$JexlExpression.evaluate(ExpressionFactory2.java:74)
at org.apache.commons.jelly.parser.EscapingExpression.evaluate(EscapingExpression.java:24)
at org.apache.commons.jelly.impl.ExpressionScript.run(ExpressionScript.java:66)
at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)

I'm not sure how to provide a repeatable condition for that bug yet, but wanted to alert you about it.  I won't investigate further on it until after the end of the working day today.

Mark Waite

On Friday, June 23, 2017 at 7:32:54 AM UTC-6, Stephen Connolly wrote:
How do you find the new UI compared with the previous one?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c2e110d7-f929-461d-8595-273e8e543d89%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/2bc996a5-b2d6-4c22-884a-a7a026cc9472%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b5045058-c67a-4d57-8ebc-d33a2c621c32%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CAO49JtGvS72PabFebSAK4upZ08fu8N09dnVSrHbhMax%2Bt0%3Dmdw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CALELY9F5V-zLHt0ftobD0_CVbdEuBVd1nv94KO-9o8m8%2BZAuTw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Loading...