Re: Maven snapshot trigger plugin for Hudson

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Maven snapshot trigger plugin for Hudson

Kohsuke Kawaguchi
Administrator
Jarkko Viinamäki wrote:
> Hi!
>
> I have implemented a new plugin for Hudson. Basically it is a trigger
> that detects changes in Maven 1.x SNAPSHOT dependencies.
>
> It would be nice to get this hosted in Hudson website like the other
> plugins.

Sure thing. Let me know your java.net id so that I can give you the
commit access.

> There are two issues with this release:
> 1. Plugin assumes that project.xml file is found with getRootDir() +
> "/workspace/project.xml". However, this might not be true if CVS used in
> legacy mode (module path is included). Is there an easy way to point to
> the actual "root"?

Yes. Relatively easy. Try AbstractProject.getModuleRoot()

I take it that your plugin works with Maven 1, not Maven 2? In that case
I'd encourage putting "maven1" somewhere in the plugin name so as not to
confuse maven2 users.

> 2. Despite some digging I could not figure out how to pass dependency
> changes to Hudson (to be listed in the change log).

Yeah, this needs some more thoughts.

>
> Otherwise it should work fine.
>
> Check it out at:
> http://www.iki.fi/wyla/hudson
>
> PS. Hudson _really_ rocks! Excellent job!
>
> Best regards,
> Jarkko Viinamäki
>
>


--
Kohsuke Kawaguchi

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Maven snapshot trigger plugin for Hudson

Kohsuke Kawaguchi
Administrator
Jarkko Viinamäki wrote:
> Hi!
>
> My java.net id is: wyla

I added you as a developer. Welcome on board.
>
> I fixed the plugin to use AbstractProject.getModuleRoot() so that part
> should be ok. I also changed the plugin name to maven1-snapshot-plugin.
>
> I also have an extension to this plugin that can poll remote Maven
> repositories (to detect new snapshot versions) but after some thinking I
> decided not to include that functionality since it slows down the
> detection process and is rarely actually needed.

Feel free to import your plugin in
https://hudson.dev.java.net/source/browse/hudson/hudson/plugins/
If you need any help, I'd be happy to help.

Personally, I would think checking the remote repository is very useful
--- since this is a trigger, it doesn't really matter if a check is fast
or slow.

>
> BR,
> Jarkko
>
> Kohsuke Kawaguchi wrote:
>> Jarkko Viinamäki wrote:
>>> Hi!
>>>
>>> I have implemented a new plugin for Hudson. Basically it is a trigger
>>> that detects changes in Maven 1.x SNAPSHOT dependencies.
>>>
>>> It would be nice to get this hosted in Hudson website like the other
>>> plugins.
>>
>> Sure thing. Let me know your java.net id so that I can give you the
>> commit access.
>>
>>> There are two issues with this release:
>>> 1. Plugin assumes that project.xml file is found with getRootDir() +
>>> "/workspace/project.xml". However, this might not be true if CVS used
>>> in legacy mode (module path is included). Is there an easy way to
>>> point to the actual "root"?
>>
>> Yes. Relatively easy. Try AbstractProject.getModuleRoot()
>>
>> I take it that your plugin works with Maven 1, not Maven 2? In that
>> case I'd encourage putting "maven1" somewhere in the plugin name so as
>> not to confuse maven2 users.
>>
>>> 2. Despite some digging I could not figure out how to pass dependency
>>> changes to Hudson (to be listed in the change log).
>>
>> Yeah, this needs some more thoughts.
>>
>>>
>>> Otherwise it should work fine.
>>>
>>> Check it out at:
>>> http://www.iki.fi/wyla/hudson
>>>
>>> PS. Hudson _really_ rocks! Excellent job!
>>>
>>> Best regards,
>>> Jarkko Viinamäki
>>>
>>>
>>
>>
>
>


--
Kohsuke Kawaguchi

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]