Remove old agent protocols?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Remove old agent protocols?

Jeff Thompson
For historical reasons, Jenkins still ships with old, deprecated
protocols, JNLP1-connect, JNLP2-connect, and JNLP3-connect. These all
have fundamental issues and known bugs. They were all superseded by the
JNLP4-connect protocol released in Jenkins 2.27 over three years ago
(October 2016). They have all been deprecated and unsupported since
Jenkins 2.75 over two years ago. Since then there have been UI messages
and an administrative monitor strongly discouraging their use. (See more
information about the protocols at
https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md )

As part of cleaning up technical debt I propose to remove these
protocols. Does anyone have any concerns? If you do, please share use
case or configuration details.

There is a proposal to add WebSockets as another agent connection
mechanism. (See
https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc 
) This may cover use cases where someone still uses the older protocols.
We could make the removal of the old protocols dependent on completion
of WebSocket support.

Jeff Thompson


--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com.
Reply | Threaded
Open this post in threaded view
|

Re: Remove old agent protocols?

slide
I'm a big +1 on this.

On Tue, Dec 3, 2019 at 11:05 AM Jeff Thompson <[hidden email]> wrote:
For historical reasons, Jenkins still ships with old, deprecated
protocols, JNLP1-connect, JNLP2-connect, and JNLP3-connect. These all
have fundamental issues and known bugs. They were all superseded by the
JNLP4-connect protocol released in Jenkins 2.27 over three years ago
(October 2016). They have all been deprecated and unsupported since
Jenkins 2.75 over two years ago. Since then there have been UI messages
and an administrative monitor strongly discouraging their use. (See more
information about the protocols at
https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md )

As part of cleaning up technical debt I propose to remove these
protocols. Does anyone have any concerns? If you do, please share use
case or configuration details.

There is a proposal to add WebSockets as another agent connection
mechanism. (See
https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc
) This may cover use cases where someone still uses the older protocols.
We could make the removal of the old protocols dependent on completion
of WebSocket support.

Jeff Thompson


--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com.


--

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: Remove old agent protocols?

Jeff Thompson

I haven't seen any other responses here than this one from Slide so I'm going to assume lack of response means there are no objections. I also haven't received any concerns about use case or configuration, so I'm not planning on tying this work as a dependency with Jesse's work with WebSockets. Both efforts can proceed independently.

I'm still working on a timeline for when these changes will go in. Currently I'm leaning towards waiting a little before making this change.

Jeff

On 12/3/19 11:58 AM, Slide wrote:
I'm a big +1 on this.

On Tue, Dec 3, 2019 at 11:05 AM Jeff Thompson <[hidden email]> wrote:
For historical reasons, Jenkins still ships with old, deprecated
protocols, JNLP1-connect, JNLP2-connect, and JNLP3-connect. These all
have fundamental issues and known bugs. They were all superseded by the
JNLP4-connect protocol released in Jenkins 2.27 over three years ago
(October 2016). They have all been deprecated and unsupported since
Jenkins 2.75 over two years ago. Since then there have been UI messages
and an administrative monitor strongly discouraging their use. (See more
information about the protocols at
https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md )

As part of cleaning up technical debt I propose to remove these
protocols. Does anyone have any concerns? If you do, please share use
case or configuration details.

There is a proposal to add WebSockets as another agent connection
mechanism. (See
https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc
) This may cover use cases where someone still uses the older protocols.
We could make the removal of the old protocols dependent on completion
of WebSocket support.

Jeff Thompson


--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com.


--
--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/00e706c8-923b-bf13-cf57-732dba27ad91%40cloudbees.com.
Reply | Threaded
Open this post in threaded view
|

Re: Remove old agent protocols?

Oleg Nenashev
+1 for removal though it should be in the developer mailing list IMHO

On Tuesday, December 10, 2019 at 8:01:08 PM UTC+1, Jeff Thompson wrote:

I haven't seen any other responses here than this one from Slide so I'm going to assume lack of response means there are no objections. I also haven't received any concerns about use case or configuration, so I'm not planning on tying this work as a dependency with Jesse's work with WebSockets. Both efforts can proceed independently.

I'm still working on a timeline for when these changes will go in. Currently I'm leaning towards waiting a little before making this change.

Jeff

On 12/3/19 11:58 AM, Slide wrote:
I'm a big +1 on this.

On Tue, Dec 3, 2019 at 11:05 AM Jeff Thompson <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="QvtN1f53BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jtho...@...> wrote:
For historical reasons, Jenkins still ships with old, deprecated
protocols, JNLP1-connect, JNLP2-connect, and JNLP3-connect. These all
have fundamental issues and known bugs. They were all superseded by the
JNLP4-connect protocol released in Jenkins 2.27 over three years ago
(October 2016). They have all been deprecated and unsupported since
Jenkins 2.75 over two years ago. Since then there have been UI messages
and an administrative monitor strongly discouraging their use. (See more
information about the protocols at
<a href="https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fremoting%2Fblob%2Fmaster%2Fdocs%2Fprotocols.md\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGOS_ENVdXDBv_KiWGbL52HiP60pw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fremoting%2Fblob%2Fmaster%2Fdocs%2Fprotocols.md\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGOS_ENVdXDBv_KiWGbL52HiP60pw&#39;;return true;">https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md )

As part of cleaning up technical debt I propose to remove these
protocols. Does anyone have any concerns? If you do, please share use
case or configuration details.

There is a proposal to add WebSockets as another agent connection
mechanism. (See
<a href="https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjep%2Fblob%2F2c137aa7884fd6360f133964422fd997351a7ebb%2Fjep%2F0000%2FREADME.adoc\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFW3_bs2R4MN7d3qQ-D4zzVaBRh4g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjep%2Fblob%2F2c137aa7884fd6360f133964422fd997351a7ebb%2Fjep%2F0000%2FREADME.adoc\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFW3_bs2R4MN7d3qQ-D4zzVaBRh4g&#39;;return true;">https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc
) This may cover use cases where someone still uses the older protocols.
We could make the removal of the old protocols dependent on completion
of WebSocket support.

Jeff Thompson


--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="QvtN1f53BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkins...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com.


--
Website: <a href="http://earl-of-code.com" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fearl-of-code.com\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNH6n4PgqhQTRQjanfDfEls_aRabFg&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fearl-of-code.com\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNH6n4PgqhQTRQjanfDfEls_aRabFg&#39;;return true;">http://earl-of-code.com
--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="QvtN1f53BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkins...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/a9c7a9a2-656e-4da0-b000-5bcae94a6cda%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: Remove old agent protocols?

Oleg Nenashev
Some updates here:
  • The deprecated protocols were removed in Remoting 3.40. Jenkins agents will not longer support these protocols
  • On the master side, the changes were integrated towards Jenkins 2.214 weekly. ETA is next Monday. The next LTS baseline after 2.204.x is expected have the protocols removed as well
  • Jenkins agent images need to be updated to the new versions of Remoting. ETA is next Monday
  • Swarm Plugin Client is updated, but we need a release
Best regards,
Oleg

On Monday, January 6, 2020 at 10:56:48 PM UTC+1, Oleg Nenashev wrote:
+1 for removal though it should be in the developer mailing list IMHO

On Tuesday, December 10, 2019 at 8:01:08 PM UTC+1, Jeff Thompson wrote:

I haven't seen any other responses here than this one from Slide so I'm going to assume lack of response means there are no objections. I also haven't received any concerns about use case or configuration, so I'm not planning on tying this work as a dependency with Jesse's work with WebSockets. Both efforts can proceed independently.

I'm still working on a timeline for when these changes will go in. Currently I'm leaning towards waiting a little before making this change.

Jeff

On 12/3/19 11:58 AM, Slide wrote:
I'm a big +1 on this.

On Tue, Dec 3, 2019 at 11:05 AM Jeff Thompson <[hidden email]> wrote:
For historical reasons, Jenkins still ships with old, deprecated
protocols, JNLP1-connect, JNLP2-connect, and JNLP3-connect. These all
have fundamental issues and known bugs. They were all superseded by the
JNLP4-connect protocol released in Jenkins 2.27 over three years ago
(October 2016). They have all been deprecated and unsupported since
Jenkins 2.75 over two years ago. Since then there have been UI messages
and an administrative monitor strongly discouraging their use. (See more
information about the protocols at
<a href="https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fremoting%2Fblob%2Fmaster%2Fdocs%2Fprotocols.md\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGOS_ENVdXDBv_KiWGbL52HiP60pw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fremoting%2Fblob%2Fmaster%2Fdocs%2Fprotocols.md\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGOS_ENVdXDBv_KiWGbL52HiP60pw&#39;;return true;">https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md )

As part of cleaning up technical debt I propose to remove these
protocols. Does anyone have any concerns? If you do, please share use
case or configuration details.

There is a proposal to add WebSockets as another agent connection
mechanism. (See
<a href="https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjep%2Fblob%2F2c137aa7884fd6360f133964422fd997351a7ebb%2Fjep%2F0000%2FREADME.adoc\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFW3_bs2R4MN7d3qQ-D4zzVaBRh4g&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fjep%2Fblob%2F2c137aa7884fd6360f133964422fd997351a7ebb%2Fjep%2F0000%2FREADME.adoc\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFW3_bs2R4MN7d3qQ-D4zzVaBRh4g&#39;;return true;">https://github.com/jenkinsci/jep/blob/2c137aa7884fd6360f133964422fd997351a7ebb/jep/0000/README.adoc
) This may cover use cases where someone still uses the older protocols.
We could make the removal of the old protocols dependent on completion
of WebSocket support.

Jeff Thompson


--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-users/0d38edaf-2cc2-d390-2332-aaa3105d9972%40cloudbees.com.


--
Website: <a href="http://earl-of-code.com" rel="nofollow" target="_blank" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fearl-of-code.com\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNH6n4PgqhQTRQjanfDfEls_aRabFg&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fearl-of-code.com\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNH6n4PgqhQTRQjanfDfEls_aRabFg&#39;;return true;">http://earl-of-code.com
--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-users/CAPiUgVeptB-Vo5fnft6d08ar-X20BHxGByN5AoCnz%2BO%2B-tcr4A%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/fecc6d4a-f418-4877-908a-001428c8339d%40googlegroups.com.