Rename of http_request artifactId

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Rename of http_request artifactId

Janario Oliveira
Hi guys,

I've renamed the artifactId of the plugin http_request to http-request-plugin.

I've added information to the lastest release under the old name https://github.com/jenkinsci/http-request-plugin/commit/72b665c15a19333836391b1bfb8cf2cbc07c7461#diff-600376dffeb79835ede4a0b285078036R38
Soon, maybe one month, I'll add it in the ignore list https://github.com/jenkins-infra/backend-update-center2/blob/master/src/main/resources/artifact-ignores.properties

But, I'm getting an error when I try to generate the release under the new name

> Failed to deploy artifacts: Could not transfer artifact org.jenkins-ci.plugins:http-request-plugin:hpi:1.9.0 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/http-request-plugin/1.9.0/http-request-plugin-1.9.0.hpi, ReasonPhrase: Forbidden. -> [Help 1]

What should I do to receive the this permission under the new name?

Thank you all.


--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c820ef02-6ba0-44f0-9754-4d714f459ab1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Rename of http_request artifactId

Jesse Glick-4
On Fri, Mar 17, 2017 at 10:50 AM, Janario Oliveira
<[hidden email]> wrote:
> I've renamed the artifactId of the plugin http_request to
> http-request-plugin.

I would advise you revert that ASAP.

First of all, there is no mechanism in Jenkins to change the ID of a
plugin after people have installed it. So users will not see an
upgrade; they will just see an unrelated plugin.

Second, the new name is wrong! Jenkins plugin names should not end in `-plugin`.

So revert the name change, and if you managed to deploy an artifact
under the new name, file an INFRA ticket to get the bogus release
blocked from the update center before people get confused.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2LsYNdffVx0-vNpGSbF__3ePz8UWKM_YCBkJvSSXNrTA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Rename of http_request artifactId

Daniel Beck

> On 17.03.2017, at 15:54, Jesse Glick <[hidden email]> wrote:
>
> First of all, there is no mechanism in Jenkins to change the ID of a
> plugin after people have installed it. So users will not see an
> upgrade; they will just see an unrelated plugin.

This. 4.5k users will be stuck on the old version, continuing to report bugs and feature requests thinking they're on the newest version there is. Not to mention possible issues if they just install the new plugin without uninstalling the old one since nothing but artifactId was changed.

I strongly recommend this be undone.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2B97C65D-F967-408A-86BA-D0FEE24FB0E2%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Rename of http_request artifactId

Janario Oliveira
In reply to this post by Jesse Glick-4


On Friday, March 17, 2017 at 11:54:28 AM UTC-3, Jesse Glick wrote:
On Fri, Mar 17, 2017 at 10:50 AM, Janario Oliveira
<<a href="javascript:" target="_blank" gdf-obfuscated-mailto="PDGol5m_BAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">janario....@...> wrote:
> I've renamed the artifactId of the plugin http_request to
> http-request-plugin.

I would advise you revert that ASAP.

First of all, there is no mechanism in Jenkins to change the ID of a
plugin after people have installed it. So users will not see an
upgrade; they will just see an unrelated plugin.
I understand that Jenkins doesn't change the ID. I added information on the last release before the rename 
It will show 2 plugins, the new one and the old one with information of rename

The reason I'm changing it is because the links and configuration points to a wrong destination
e.g. https://plugins.jenkins.io/http_request
Wrong:
 Github https://github.com/jenkinsci/http_request-plugin
 Jira http://issues.jenkins-ci.org/secure/IssueNavigator.jspa?mode=hide&reset=true&jqlQuery=project+%3D+JENKINS+AND+status+in+%28Open%2C+%22In+Progress%22%2C+Reopened%29+AND+component+%3D+%27http_request-plugin%27
 Changes https://github.com/jenkinsci/http_request-plugin/compare/http_request-1.8.14...master
And It goes in other places.

If there is a way to fix all this, I could keep the old name


Second, the new name is wrong! Jenkins plugin names should not end in `-plugin`.
 I could use http-request

So revert the name change, and if you managed to deploy an artifact
under the new name, file an INFRA ticket to get the bogus release
blocked from the update center before people get confused.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7519fb14-ca49-4691-9da6-f4c514c21979%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Rename of http_request artifactId

Daniel Beck

> On 17.03.2017, at 16:28, Janario Oliveira <[hidden email]> wrote:
>
> And It goes in other places.
>
> If there is a way to fix all this, I could keep the old name

Jira link will be removed soon anyway since we currently have no great way to handle the naming inconsistencies there -- and it's not just your plugin.

And for GitHub URL, there's https://issues.jenkins-ci.org/browse/WEBSITE-332 in progress that will take care of that.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/95E808B9-B80D-4D20-919A-B8FF5E95D300%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Rename of http_request artifactId

Janario Oliveira
Looks good to me with github fix.
Ok, I'll wait the issue.

Thank you all guys.

On Friday, March 17, 2017 at 1:52:10 PM UTC-3, Daniel Beck wrote:

> On 17.03.2017, at 16:28, Janario Oliveira <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="1MQx3wXGBAAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">janario....@...> wrote:
>
> And It goes in other places.
>
> If there is a way to fix all this, I could keep the old name

Jira link will be removed soon anyway since we currently have no great way to handle the naming inconsistencies there -- and it's not just your plugin.

And for GitHub URL, there's <a href="https://issues.jenkins-ci.org/browse/WEBSITE-332" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fissues.jenkins-ci.org%2Fbrowse%2FWEBSITE-332\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHfMpaxQaJCDZqgWrdSmj1cWBX11A&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fissues.jenkins-ci.org%2Fbrowse%2FWEBSITE-332\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHfMpaxQaJCDZqgWrdSmj1cWBX11A&#39;;return true;">https://issues.jenkins-ci.org/browse/WEBSITE-332 in progress that will take care of that.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c5b8394e-8810-4b51-b862-35d77a4dcb5d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.