Request for plugin commit access

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Request for plugin commit access

Peter Reilly-2
Hi Kohsuke,
My checkstyle  plugin for hudson is nearly
ready for public release.

Could I get access to the plugins directory.

The plugin may be able to do pmd (and findbugs)
as well as checkstyle reporting -
so I am a little uncertain what to call it.

My javanet id is : [hidden email].

Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Request for plugin commit access

Kohsuke Kawaguchi
Administrator
Peter Reilly wrote:
> Hi Kohsuke,
> My checkstyle  plugin for hudson is nearly
> ready for public release.

Cool!

> Could I get access to the plugins directory.

Of course.

> The plugin may be able to do pmd (and findbugs)
> as well as checkstyle reporting -
> so I am a little uncertain what to call it.

Ah, OK. Hmm. I'll leave it up to you, but we can rename a plugin later
if you'd like.

> My javanet id is : [hidden email].

That's probably your e-mail address you used to subscribe to java.net,
but java.net id doesn't contain '.' or '@'. It will be something like
'kohsuke' or 'al_xipe', etc.


--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Request for plugin commit access

Peter Reilly-2
On 7/23/07, Kohsuke Kawaguchi <[hidden email]> wrote:

> Peter Reilly wrote:
> > Hi Kohsuke,
> > My checkstyle  plugin for hudson is nearly
> > ready for public release.
>
> Cool!
>
> > Could I get access to the plugins directory.
>
> Of course.
>
> > The plugin may be able to do pmd (and findbugs)
> > as well as checkstyle reporting -
> > so I am a little uncertain what to call it.
>
> Ah, OK. Hmm. I'll leave it up to you, but we can rename a plugin later
> if you'd like.
>
> > My javanet id is : [hidden email].
>
> That's probably your e-mail address you used to subscribe to java.net,
> but java.net id doesn't contain '.' or '@'. It will be something like
> 'kohsuke' or 'al_xipe', etc.
Opps,
yes, it it "peterkittreilly".
I always use the gmail address when logging in.

Peter

>
>
> --
> Kohsuke Kawaguchi
> Sun Microsystems                   [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Request for plugin commit access

Kohsuke Kawaguchi
Administrator
Peter Reilly wrote:
> yes, it it "peterkittreilly".
> I always use the gmail address when logging in.

You are all set. Welcome on board.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Request for plugin commit access

Ulli Hafner-2
In reply to this post by Peter Reilly-2
Hi Peter,

Good to see! I'll checkout your sources and look if I can reuse your
code for the findbugs reports.
How do you present the warning reports? Is it easy to adapt this to
findbugs?

BTW: I uploaded the findbugs plugin to CVS now, so you can have a
look...

Best regards, Ulli

> -----Original Message-----
> From: Peter Reilly [mailto:[hidden email]]
> Sent: Monday, July 23, 2007 8:06 PM
> To: [hidden email]
> Subject: Request for plugin commit access
>
> Hi Kohsuke,
> My checkstyle  plugin for hudson is nearly ready for public release.
>
> Could I get access to the plugins directory.
>
> The plugin may be able to do pmd (and findbugs) as well as
> checkstyle reporting - so I am a little uncertain what to call it.
>
> My javanet id is : [hidden email].
>
> Peter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Request for plugin commit access

Peter Reilly-2
On 7/24/07, Hafner Ullrich <[hidden email]> wrote:
> Hi Peter,
>
> Good to see! I'll checkout your sources and look if I can reuse your
> code for the findbugs reports.
> How do you present the warning reports? Is it easy to adapt this to
> findbugs?

I am writing html reports - similar to the checkstyle reports. The code
is not yet compete but should be ready in a couple of
days. (depending on access to the home computer ;-).

It is quite easy to parse fingbugs and pmd xml files - my internal
classes do not depend on checksyle, so I think that it would
be easy to get the plugin to deal with all three report types.


>
> BTW: I uploaded the findbugs plugin to CVS now, so you can have a
> look...

Thanks, am looking now.

Cheers,
Peter

>
> Best regards, Ulli
>
> > -----Original Message-----
> > From: Peter Reilly [mailto:[hidden email]]
> > Sent: Monday, July 23, 2007 8:06 PM
> > To: [hidden email]
> > Subject: Request for plugin commit access
> >
> > Hi Kohsuke,
> > My checkstyle  plugin for hudson is nearly ready for public release.
> >
> > Could I get access to the plugins directory.
> >
> > The plugin may be able to do pmd (and findbugs) as well as
> > checkstyle reporting - so I am a little uncertain what to call it.
> >
> > My javanet id is : [hidden email].
> >
> > Peter
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Request for plugin commit access

Kohsuke Kawaguchi
Administrator
Peter Reilly wrote:

> On 7/24/07, Hafner Ullrich <[hidden email]> wrote:
>> Hi Peter,
>>
>> Good to see! I'll checkout your sources and look if I can reuse your
>> code for the findbugs reports.
>> How do you present the warning reports? Is it easy to adapt this to
>> findbugs?
>
> I am writing html reports - similar to the checkstyle reports. The code
> is not yet compete but should be ready in a couple of
> days. (depending on access to the home computer ;-).
>
> It is quite easy to parse fingbugs and pmd xml files - my internal
> classes do not depend on checksyle, so I think that it would
> be easy to get the plugin to deal with all three report types.
I haven't looked at neither plugin yet (although I do plan on using
findbugs plugin as some of my users are asking for it), so maybe I'm
completely off base, but ...

In general, a good plugin tends to be very specific about the target (in
this case findsbugs and checkstyle), so at some point this is at odds
with one generic plugin that can deal with many different targets.

An example that I can talk fairly well is JUnit/NUnit/JavaTest. They are
all similar, in the sense that they are all test harnesses that produce
some kind of XML output. But when you try to do a good job, it becomes
apparent that it's not just a matter of parsing three different files.

For example, in NUnit there's no such things as "packages"; they are
called "namespaces" instead. So the UI should be different. JavaTest has
a provision of skipped tests, which JUnit doesn't have. So here even the
underlying model is slightly different. It's probably possible to map
JavaTest model to JUnit model, and that's very cheap in terms of the
development cost, but again if you are to do a good plugin, in the end
you'll often need separate plugins, so that you can adjust to fine
details of the target (even though they could share some of the code
underneath, as JUnit and JavaTest does.)

I don't know how this applies to findbugs/checkstyle case, as I lack the
domain expertise here, but I guess what I'm saying is that two plugins
could very well make sense.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

smime.p7s (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Request for plugin commit access

Ulli Hafner-2
Well, I think findbugs, checkstyle and pmd are quite similar, so using
one plug-in should work quite good.

I'm looking forward seeing your code in CVS, so we don't duplicate too
much code:-) My findbugs plugin is already checked in and actually has
only a single dependeny to findbugs (XML scanning strategy) - you could
build and install it from source (I had look to upload it to the
homepage up to now...)

Ulli



-----Original Message-----
From: Kohsuke Kawaguchi [mailto:[hidden email]]
Sent: Dienstag, 24. Juli 2007 21:22
To: [hidden email]
Subject: Re: Request for plugin commit access

Peter Reilly wrote:

> On 7/24/07, Hafner Ullrich <[hidden email]> wrote:
>> Hi Peter,
>>
>> Good to see! I'll checkout your sources and look if I can reuse your
>> code for the findbugs reports.
>> How do you present the warning reports? Is it easy to adapt this to
>> findbugs?
>
> I am writing html reports - similar to the checkstyle reports. The
> code is not yet compete but should be ready in a couple of days.
> (depending on access to the home computer ;-).
>
> It is quite easy to parse fingbugs and pmd xml files - my internal
> classes do not depend on checksyle, so I think that it would be easy
> to get the plugin to deal with all three report types.

I haven't looked at neither plugin yet (although I do plan on using
findbugs plugin as some of my users are asking for it), so maybe I'm
completely off base, but ...

In general, a good plugin tends to be very specific about the target (in
this case findsbugs and checkstyle), so at some point this is at odds
with one generic plugin that can deal with many different targets.

An example that I can talk fairly well is JUnit/NUnit/JavaTest. They are
all similar, in the sense that they are all test harnesses that produce
some kind of XML output. But when you try to do a good job, it becomes
apparent that it's not just a matter of parsing three different files.

For example, in NUnit there's no such things as "packages"; they are
called "namespaces" instead. So the UI should be different. JavaTest has
a provision of skipped tests, which JUnit doesn't have. So here even the
underlying model is slightly different. It's probably possible to map
JavaTest model to JUnit model, and that's very cheap in terms of the
development cost, but again if you are to do a good plugin, in the end
you'll often need separate plugins, so that you can adjust to fine
details of the target (even though they could share some of the code
underneath, as JUnit and JavaTest does.)

I don't know how this applies to findbugs/checkstyle case, as I lack the
domain expertise here, but I guess what I'm saying is that two plugins
could very well make sense.

--
Kohsuke Kawaguchi
Sun Microsystems                   [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Request for plugin commit access

Kohsuke Kawaguchi
Administrator
When you'd like me to run a release goal to push it to the docs&files
section, etc, just let me know.

2007/7/25, Hafner Ullrich <[hidden email]>:

> Well, I think findbugs, checkstyle and pmd are quite similar, so using
> one plug-in should work quite good.
>
> I'm looking forward seeing your code in CVS, so we don't duplicate too
> much code:-) My findbugs plugin is already checked in and actually has
> only a single dependeny to findbugs (XML scanning strategy) - you could
> build and install it from source (I had look to upload it to the
> homepage up to now...)
>
> Ulli
>
>
>
> -----Original Message-----
> From: Kohsuke Kawaguchi [mailto:[hidden email]]
> Sent: Dienstag, 24. Juli 2007 21:22
> To: [hidden email]
> Subject: Re: Request for plugin commit access
>
> Peter Reilly wrote:
> > On 7/24/07, Hafner Ullrich <[hidden email]> wrote:
> >> Hi Peter,
> >>
> >> Good to see! I'll checkout your sources and look if I can reuse your
> >> code for the findbugs reports.
> >> How do you present the warning reports? Is it easy to adapt this to
> >> findbugs?
> >
> > I am writing html reports - similar to the checkstyle reports. The
> > code is not yet compete but should be ready in a couple of days.
> > (depending on access to the home computer ;-).
> >
> > It is quite easy to parse fingbugs and pmd xml files - my internal
> > classes do not depend on checksyle, so I think that it would be easy
> > to get the plugin to deal with all three report types.
>
> I haven't looked at neither plugin yet (although I do plan on using
> findbugs plugin as some of my users are asking for it), so maybe I'm
> completely off base, but ...
>
> In general, a good plugin tends to be very specific about the target (in
> this case findsbugs and checkstyle), so at some point this is at odds
> with one generic plugin that can deal with many different targets.
>
> An example that I can talk fairly well is JUnit/NUnit/JavaTest. They are
> all similar, in the sense that they are all test harnesses that produce
> some kind of XML output. But when you try to do a good job, it becomes
> apparent that it's not just a matter of parsing three different files.
>
> For example, in NUnit there's no such things as "packages"; they are
> called "namespaces" instead. So the UI should be different. JavaTest has
> a provision of skipped tests, which JUnit doesn't have. So here even the
> underlying model is slightly different. It's probably possible to map
> JavaTest model to JUnit model, and that's very cheap in terms of the
> development cost, but again if you are to do a good plugin, in the end
> you'll often need separate plugins, so that you can adjust to fine
> details of the target (even though they could share some of the code
> underneath, as JUnit and JavaTest does.)
>
> I don't know how this applies to findbugs/checkstyle case, as I lack the
> domain expertise here, but I guess what I'm saying is that two plugins
> could very well make sense.
>
> --
> Kohsuke Kawaguchi
> Sun Microsystems                   [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Kohsuke Kawaguchi

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]