Request to become maintainer of the Parameterized Remote Trigger Plugin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Request to become maintainer of the Parameterized Remote Trigger Plugin

Kai-Hsiang Chang
Hi All,

this plugin hasn't been updated for at least 2 years, 

I'd like to ask the permission to maintain the plugin.

please help me with that.

Thanks

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEcVQbSswHsgN9y%2Be-15f1gGu9rJh0tCB_Z3Uu33Luj1GMq6%2Bg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Daniel Beck

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Tony Noble
In reply to this post by Kai-Hsiang Chang
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9HLeeV3Z-kbohH8CAsbnH_mKfgzMiy%2BHrPezCUJJ2r%3DGw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Kai-Hsiang Chang
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="SqoerAkNAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">m...@...> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="SqoerAkNAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">cash...@...> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="SqoerAkNAQAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e11fca58-deff-4c7d-b0c7-4b51a73e6b1f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Oleg Nenashev
I would like to point out that there is a major work being done on Pipeline compatibility in https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ec2057c8-3278-4d51-b70e-8c470d1b9439%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Alexander Link-2

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Tony Noble
I did spend some time looking at that PR, but it appears as though there is still work to be done on it, or at least, changes requested.

Is that not the case?  I got a little lost trying to figure out what was still to be done.

Tony

On Tue, Apr 24, 2018 at 12:18 PM, 'Alexander Link' via Jenkins Developers <[hidden email]> wrote:

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]om.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9Ea8ee-CS2WJp8ikex-%2Bbe1wHfAwQD0ojCcgsfjbeZcnw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Alexander Link-2
Hi Tony,

We incorporated much of the feedback by Oleg (thanks again for the review!), but yes, I think there are still some unprocessed comments (those without +1 marker). We need to decide how urgent they are - currently we are not working on them due to capacity reasons.

Nevertheless you need to know we are using this version of the plugin productively on more than hundred (team) Jenkinses in our company. Identified bugs in the last 2 years have been fixed, this most likely includes bugs which are still contained in the current official version of the plugin.

Kind regards,
Alex


Am Dienstag, 24. April 2018 13:45:04 UTC+2 schrieb Tony Noble:
I did spend some time looking at that PR, but it appears as though there is still work to be done on it, or at least, changes requested.

Is that not the case?  I got a little lost trying to figure out what was still to be done.

Tony

On Tue, Apr 24, 2018 at 12:18 PM, 'Alexander Link' via Jenkins Developers <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="oHJhhkJEAgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com> wrote:

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: <a href="https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;">https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="oHJhhkJEAgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Kai-Hsiang Chang
Hi Alex, 

If this version has been tested & run for 2 years in your company, I think it's okay to just apply this huge PR and refine the code quality & the comments later. 
But this is just my opinion, I'm not the maintainer. 

2018-04-24 20:22 GMT+08:00 'Alexander Link' via Jenkins Developers <[hidden email]>:
Hi Tony,

We incorporated much of the feedback by Oleg (thanks again for the review!), but yes, I think there are still some unprocessed comments (those without +1 marker). We need to decide how urgent they are - currently we are not working on them due to capacity reasons.

Nevertheless you need to know we are using this version of the plugin productively on more than hundred (team) Jenkinses in our company. Identified bugs in the last 2 years have been fixed, this most likely includes bugs which are still contained in the current official version of the plugin.

Kind regards,
Alex


Am Dienstag, 24. April 2018 13:45:04 UTC+2 schrieb Tony Noble:
I did spend some time looking at that PR, but it appears as though there is still work to be done on it, or at least, changes requested.

Is that not the case?  I got a little lost trying to figure out what was still to be done.

Tony

On Tue, Apr 24, 2018 at 12:18 PM, 'Alexander Link' via Jenkins Developers <[hidden email]> wrote:

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email]om.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEcVQbRuM6PAmZN0NMQ4aLm15xv0J%2BswSnmUxXPz3esP%2Bc8cJQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Alexander Link-2
Hi,

I collected all open review comments: https://github.com/sap-production/parameterized-remote-trigger-plugin/issues/20
We will check the urgency and process the urgent ones.

But in general we are using the plugin productively and never had severe issues. Minor bugs (recognized in our scenarios) have been fixed.
I would also vote for merging this PR first. We already tried to split it up into single meaningful PRs but this is almost not possible anymore.

It seems you will be the maintainer in future, so you have to decide if the changes are good enough :)

Thanks a lot and kind regards,
Alex

Am Dienstag, 24. April 2018 15:45:22 UTC+2 schrieb Kai-Hsiang Chang:
Hi Alex, 

If this version has been tested & run for 2 years in your company, I think it's okay to just apply this huge PR and refine the code quality & the comments later. 
But this is just my opinion, I'm not the maintainer. 

2018-04-24 20:22 GMT+08:00 'Alexander Link' via Jenkins Developers <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="s7l-ItNKAgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com>:
Hi Tony,

We incorporated much of the feedback by Oleg (thanks again for the review!), but yes, I think there are still some unprocessed comments (those without +1 marker). We need to decide how urgent they are - currently we are not working on them due to capacity reasons.

Nevertheless you need to know we are using this version of the plugin productively on more than hundred (team) Jenkinses in our company. Identified bugs in the last 2 years have been fixed, this most likely includes bugs which are still contained in the current official version of the plugin.

Kind regards,
Alex


Am Dienstag, 24. April 2018 13:45:04 UTC+2 schrieb Tony Noble:
I did spend some time looking at that PR, but it appears as though there is still work to be done on it, or at least, changes requested.

Is that not the case?  I got a little lost trying to figure out what was still to be done.

Tony

On Tue, Apr 24, 2018 at 12:18 PM, 'Alexander Link' via Jenkins Developers <[hidden email]> wrote:

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: <a href="https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;">https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit <a href="https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe&#39;;return true;">https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="s7l-ItNKAgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9f9e29e4-6810-48d7-ad0c-81ee3a1f51a9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Kai-Hsiang Chang
Hi Daniel,

it seems no response from the owner, maybe we can start the process? 


Alexander Link於 2018年4月27日星期五 UTC+8下午2時55分19秒寫道:
Hi,

I collected all open review comments: <a href="https://github.com/sap-production/parameterized-remote-trigger-plugin/issues/20" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Fissues%2F20\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEHWuZM69lpfWQ0joqiNIBFGLPReA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Fissues%2F20\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEHWuZM69lpfWQ0joqiNIBFGLPReA&#39;;return true;">https://github.com/sap-production/parameterized-remote-trigger-plugin/issues/20
We will check the urgency and process the urgent ones.

But in general we are using the plugin productively and never had severe issues. Minor bugs (recognized in our scenarios) have been fixed.
I would also vote for merging this PR first. We already tried to split it up into single meaningful PRs but this is almost not possible anymore.

It seems you will be the maintainer in future, so you have to decide if the changes are good enough :)

Thanks a lot and kind regards,
Alex

Am Dienstag, 24. April 2018 15:45:22 UTC+2 schrieb Kai-Hsiang Chang:
Hi Alex, 

If this version has been tested & run for 2 years in your company, I think it's okay to just apply this huge PR and refine the code quality & the comments later. 
But this is just my opinion, I'm not the maintainer. 

2018-04-24 20:22 GMT+08:00 'Alexander Link' via Jenkins Developers <[hidden email]>:
Hi Tony,

We incorporated much of the feedback by Oleg (thanks again for the review!), but yes, I think there are still some unprocessed comments (those without +1 marker). We need to decide how urgent they are - currently we are not working on them due to capacity reasons.

Nevertheless you need to know we are using this version of the plugin productively on more than hundred (team) Jenkinses in our company. Identified bugs in the last 2 years have been fixed, this most likely includes bugs which are still contained in the current official version of the plugin.

Kind regards,
Alex


Am Dienstag, 24. April 2018 13:45:04 UTC+2 schrieb Tony Noble:
I did spend some time looking at that PR, but it appears as though there is still work to be done on it, or at least, changes requested.

Is that not the case?  I got a little lost trying to figure out what was still to be done.

Tony

On Tue, Apr 24, 2018 at 12:18 PM, 'Alexander Link' via Jenkins Developers <[hidden email]> wrote:

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: <a href="https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;">https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit <a href="https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe&#39;;return true;">https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e820cc7f-1e91-442f-8206-c78efa05c9ee%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer of the Parameterized Remote Trigger Plugin

Oleg Nenashev
Hi all,

Cristoph has been pinged on April 20 in this thread.So yes, we can do the permission transfer.

I have granted permissions to Kai-Hsiang and Tony. Kai-Hsiang is also a default assignee in JIRA now. In order to do a release, you will also need to update https://github.com/jenkins-infra/repository-permissions-updater.

Welcome aboard!

Best regards,
Oleg

On Thursday, May 10, 2018 at 8:55:53 AM UTC+2, Kai-Hsiang Chang wrote:
Hi Daniel,

it seems no response from the owner, maybe we can start the process? 


Alexander Link於 2018年4月27日星期五 UTC+8下午2時55分19秒寫道:
Hi,

I collected all open review comments: <a href="https://github.com/sap-production/parameterized-remote-trigger-plugin/issues/20" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Fissues%2F20\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEHWuZM69lpfWQ0joqiNIBFGLPReA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Fissues%2F20\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEHWuZM69lpfWQ0joqiNIBFGLPReA&#39;;return true;">https://github.com/sap-production/parameterized-remote-trigger-plugin/issues/20
We will check the urgency and process the urgent ones.

But in general we are using the plugin productively and never had severe issues. Minor bugs (recognized in our scenarios) have been fixed.
I would also vote for merging this PR first. We already tried to split it up into single meaningful PRs but this is almost not possible anymore.

It seems you will be the maintainer in future, so you have to decide if the changes are good enough :)

Thanks a lot and kind regards,
Alex

Am Dienstag, 24. April 2018 15:45:22 UTC+2 schrieb Kai-Hsiang Chang:
Hi Alex, 

If this version has been tested & run for 2 years in your company, I think it's okay to just apply this huge PR and refine the code quality & the comments later. 
But this is just my opinion, I'm not the maintainer. 

2018-04-24 20:22 GMT+08:00 'Alexander Link' via Jenkins Developers <[hidden email]>:
Hi Tony,

We incorporated much of the feedback by Oleg (thanks again for the review!), but yes, I think there are still some unprocessed comments (those without +1 marker). We need to decide how urgent they are - currently we are not working on them due to capacity reasons.

Nevertheless you need to know we are using this version of the plugin productively on more than hundred (team) Jenkinses in our company. Identified bugs in the last 2 years have been fixed, this most likely includes bugs which are still contained in the current official version of the plugin.

Kind regards,
Alex


Am Dienstag, 24. April 2018 13:45:04 UTC+2 schrieb Tony Noble:
I did spend some time looking at that PR, but it appears as though there is still work to be done on it, or at least, changes requested.

Is that not the case?  I got a little lost trying to figure out what was still to be done.

Tony

On Tue, Apr 24, 2018 at 12:18 PM, 'Alexander Link' via Jenkins Developers <[hidden email]> wrote:

Hi,

 

as Oleg mentioned we did many changes to this plugin in the last 2 years – in our fork unfortunately, since contribution did not work due to missing maintainers.

You find all changes in our openSource branch: <a href="https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fsap-production%2Fparameterized-remote-trigger-plugin%2Ftree%2FopenSource\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHHhta4jSjmYt4j48h1e5ra4Ona8Q&#39;;return true;">https://github.com/sap-production/parameterized-remote-trigger-plugin/tree/openSource

 

We don’t have enough resources to become maintainers ourselves, but we are happy to support you with this plugin.

 

My recommendation would be to decide on this PR first to avoid later conflicts: <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32

 

Kind regards, Alex

 

PS: Here some additional comments about the Pull Request:

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-373000207\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGQuEAMqltBPvz1mo8HEse1TWfzHQ&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-373000207

<a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32%23issuecomment-338175831\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGWQZUdAek775DxxdflghBIT-a_yA&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32#issuecomment-338175831




Am Dienstag, 24. April 2018 10:31:16 UTC+2 schrieb Oleg Nenashev:
I would like to point out that there is a major work being done on Pipeline compatibility in <a href="https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Fjenkinsci%2Fparameterized-remote-trigger-plugin%2Fpull%2F32\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFkQ5uLfJA8r1XP2de_QJyyxApqbg&#39;;return true;">https://github.com/jenkinsci/parameterized-remote-trigger-plugin/pull/32 . It would be great to invite Alejandra Ferreiro Vidal and Alexander Link to this discussion. Will do that.

BR, Oleg

On Monday, April 23, 2018 at 8:13:54 AM UTC+2, Kai-Hsiang Chang wrote:
@Tony, thx for the cc.

github id: cashlalala
Jenkins JIRA id: cashlalala

Tony Noble於 2018年4月20日星期五 UTC+8下午8時41分52秒寫道:
I'll happily co-maintain if required.  There's a PR needing to be merged to make it work with CSRF protection (that I've suggested a minor change to) that really could do with being applied, amongst others.

Christoph shows as last person to make any git commits, so I've cc'd him.

Tony

github id: TonyNoble
Jenkins JIRA id: stealthdj

On Fri, Apr 20, 2018 at 9:11 AM, Daniel Beck <[hidden email]> wrote:

> On 20. Apr 2018, at 03:51, Kai-Hsiang Chang <[hidden email]> wrote:
>
> this plugin hasn't been updated for at least 2 years,
>
> I'd like to ask the permission to maintain the plugin.
>
> please help me with that.
>

Please follow the instructions from <a href="https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fwiki.jenkins.io%2Fdisplay%2FJENKINS%2FAdopt%2Ba%2BPlugin%23AdoptaPlugin-IknowwhichpluginIwanttohelpwith%2CwhatshouldIdonow\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFTq6pKVGGYeesvRAeX6d6FP6ICCQ&#39;;return true;">https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-IknowwhichpluginIwanttohelpwith,whatshouldIdonow?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/EA80C67F-95F0-4E4C-A83C-4451B8439B56%40beckweb.net.
For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/372bf671-47a6-4fa1-ae10-132599a3ca28%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit <a href="https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe&#39;;return true;">https://groups.google.com/d/topic/jenkinsci-dev/y1Sv9MQhyaY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/39618b89-3d24-4956-b571-19da5bbfb1d6%40googlegroups.com.

For more options, visit <a href="https://groups.google.com/d/optout" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/55c9f518-e458-41b9-8e95-fa63e0302d1e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.