Request to become maintainer on docker-plugin

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Request to become maintainer on docker-plugin

nicolas de loof-2
Hi folks,

docker-plugins as 20 pull requests pending for review and no new commits since Nov 16th. 
I volunteer to adopt this plugin. Especially I'd like to have docker-plugin support docker swarm mode, so it can distribute builds on a cluster out of the box.

Github-ID: ndeloof

Jenkins-ID: ndeloof


Cheers,

Nicolas

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJznO6cMS7hWnLDxfPk%2BqHK9O-Z3ye1LOSikG7iHRabrwPw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

Oleg Nenashev
Hi,

From the quality PoV, I would really suggest deprecating Docker plugin and recommending Yet Another Docker plugin instead. That plugin progressed much more in terms of stability and Cloud API "implementation correctness" while it's still compatible with Docker Plugin use-cases. Working on Docker Plugin is a valiant goal, but I am afraid it will require re-implementing fixes already available in YAD.

Unfortunately, we cannot recommend YAD instead of Docker plugin, because the plugin is outside the Jenkins organization governance. I have contacted the maintainer multiple times, he declines to move the plugin.

+1 from me regarding the Docker plugin ownership handover though

BR, Oleg



вторник, 5 сентября 2017 г., 18:20:46 UTC+1 пользователь nicolas de loof написал:
Hi folks,

docker-plugins as 20 pull requests pending for review and no new commits since Nov 16th. 
I volunteer to adopt this plugin. Especially I'd like to have docker-plugin support docker swarm mode, so it can distribute builds on a cluster out of the box.

Github-ID: ndeloof

Jenkins-ID: ndeloof


Cheers,

Nicolas

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/90e2e932-b739-4ce4-b8be-162434f7b1fc%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

Nigel Magnay
In reply to this post by nicolas de loof-2
Please - go for it. I don't have the bandwidth these days to support it in anything like a timely manner.

On Tue, 5 Sep 2017 at 18:20, nicolas de loof <[hidden email]> wrote:
Hi folks,

docker-plugins as 20 pull requests pending for review and no new commits since Nov 16th. 
I volunteer to adopt this plugin. Especially I'd like to have docker-plugin support docker swarm mode, so it can distribute builds on a cluster out of the box.

Github-ID: ndeloof

Jenkins-ID: ndeloof


Cheers,

Nicolas

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPYP83S68h76obfuTvDAihHTRZ88p6uOmdmzHeT1K23XY4Oxtg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

Baptiste MATHUS
As Nigel gave his +1, I went ahead and made you committer Nicolas. Remember to file the necessary PR on https://github.com/jenkins-infra/repository-permissions-updater if/when you want to release.

I tend to agree with Oleg, probably some cleanup already occurred in YAD, but also agreed it's a very borderline plugin in terms of governance: hosted outside the org, but still publishing releases...

2017-09-06 9:03 GMT+02:00 Nigel Magnay <[hidden email]>:
Please - go for it. I don't have the bandwidth these days to support it in anything like a timely manner.

On Tue, 5 Sep 2017 at 18:20, nicolas de loof <[hidden email]> wrote:
Hi folks,

docker-plugins as 20 pull requests pending for review and no new commits since Nov 16th. 
I volunteer to adopt this plugin. Especially I'd like to have docker-plugin support docker swarm mode, so it can distribute builds on a cluster out of the box.

Github-ID: ndeloof

Jenkins-ID: ndeloof


Cheers,

Nicolas

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPYP83S68h76obfuTvDAihHTRZ88p6uOmdmzHeT1K23XY4Oxtg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7bR0Cmy8u%3DfAURRwTxW%3DZt1J95VDvO3uZHeTtAka5-wQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

Richard Bywater-2
@Nicolas - Interestingly out of the Docker plugin implementations I've tried so far, https://github.com/jenkinsci/docker-slaves-plugin has come closest to working the way I'd expect. Do you see that you'd roll some of that work into the Docker plugin or do it going down a completely different path?

Richard.

On Wed, 6 Sep 2017 at 20:10 Baptiste Mathus <[hidden email]> wrote:
As Nigel gave his +1, I went ahead and made you committer Nicolas. Remember to file the necessary PR on https://github.com/jenkins-infra/repository-permissions-updater if/when you want to release.

I tend to agree with Oleg, probably some cleanup already occurred in YAD, but also agreed it's a very borderline plugin in terms of governance: hosted outside the org, but still publishing releases...

2017-09-06 9:03 GMT+02:00 Nigel Magnay <[hidden email]>:
Please - go for it. I don't have the bandwidth these days to support it in anything like a timely manner.

On Tue, 5 Sep 2017 at 18:20, nicolas de loof <[hidden email]> wrote:
Hi folks,

docker-plugins as 20 pull requests pending for review and no new commits since Nov 16th. 
I volunteer to adopt this plugin. Especially I'd like to have docker-plugin support docker swarm mode, so it can distribute builds on a cluster out of the box.

Github-ID: ndeloof

Jenkins-ID: ndeloof


Cheers,

Nicolas

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPYP83S68h76obfuTvDAihHTRZ88p6uOmdmzHeT1K23XY4Oxtg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7bR0Cmy8u%3DfAURRwTxW%3DZt1J95VDvO3uZHeTtAka5-wQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMui947N%2Bp9i5ojJmxNNWEDdJusC9tu%3Da%3DXD4snzQaBdzoG4xQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

nicolas de loof-2
I still plan to work on docker-slaves plugin, but if possible I indeed would like to introduce some bits from it into docker-plugin. Typically ability to create an agent by combining containers. But too early to tell you more until I've spent some more hours in docker-plugin codebase :P

2017-09-06 10:59 GMT+02:00 Richard Bywater <[hidden email]>:
@Nicolas - Interestingly out of the Docker plugin implementations I've tried so far, https://github.com/jenkinsci/docker-slaves-plugin has come closest to working the way I'd expect. Do you see that you'd roll some of that work into the Docker plugin or do it going down a completely different path?

Richard.

On Wed, 6 Sep 2017 at 20:10 Baptiste Mathus <[hidden email]> wrote:
As Nigel gave his +1, I went ahead and made you committer Nicolas. Remember to file the necessary PR on https://github.com/jenkins-infra/repository-permissions-updater if/when you want to release.

I tend to agree with Oleg, probably some cleanup already occurred in YAD, but also agreed it's a very borderline plugin in terms of governance: hosted outside the org, but still publishing releases...

2017-09-06 9:03 GMT+02:00 Nigel Magnay <[hidden email]>:
Please - go for it. I don't have the bandwidth these days to support it in anything like a timely manner.

On Tue, 5 Sep 2017 at 18:20, nicolas de loof <[hidden email]> wrote:
Hi folks,

docker-plugins as 20 pull requests pending for review and no new commits since Nov 16th. 
I volunteer to adopt this plugin. Especially I'd like to have docker-plugin support docker swarm mode, so it can distribute builds on a cluster out of the box.

Github-ID: ndeloof

Jenkins-ID: ndeloof


Cheers,

Nicolas

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPYP83S68h76obfuTvDAihHTRZ88p6uOmdmzHeT1K23XY4Oxtg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7bR0Cmy8u%3DfAURRwTxW%3DZt1J95VDvO3uZHeTtAka5-wQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzm9k66C%3DFBC51VyZddNaXXva-kQWOi6CBn56P%2B5OkdS_w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

Jesse Glick-4
In reply to this post by Oleg Nenashev
On Tue, Sep 5, 2017 at 8:28 PM, Oleg Nenashev <[hidden email]> wrote:
> […] while it's still compatible with Docker Plugin use-cases

One of my reservations about both the `docker-plugin` and the
`yet-another-docker-plugin` (BTW both incorrectly include `-plugin` in
the `artifactId`) is that they try to solve too many things, and are
cluttered with various builders you do not really need. A plugin
should either focus on letting a job request an image for specific
build steps, as `docker-workflow` and
`docker-custom-build-environment` do; or provide a solid `Cloud`
implementation for the case that the whole agent JVM runs inside a
globally configured container (IMO the main reason to use
`docker-plugin`); or something in between, as `docker-slaves`
creatively attempts.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr04rUG_93UkFQv3vwqMVxvnWfE8RFUaQ-C%2B3jRy%2BvAWKw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Request to become maintainer on docker-plugin

nicolas de loof-2


2017-09-06 16:15 GMT+02:00 Jesse Glick <[hidden email]>:
On Tue, Sep 5, 2017 at 8:28 PM, Oleg Nenashev <[hidden email]> wrote:
> […] while it's still compatible with Docker Plugin use-cases

One of my reservations about both the `docker-plugin` and the
`yet-another-docker-plugin` (BTW both incorrectly include `-plugin` in
the `artifactId`) is that they try to solve too many things, and are
cluttered with various builders you do not really need. A plugin
should either focus on letting a job request an image for specific
build steps, as `docker-workflow` and
`docker-custom-build-environment` do; or provide a solid `Cloud`
implementation for the case that the whole agent JVM runs inside a
globally configured container (IMO the main reason to use
`docker-plugin`); or something in between, as `docker-slaves`
creatively attempts.

I totally agree, and I'm not sure how to fix this. I wonder docker-plugin could be refactored so the cloud agents part is extracted in some "docker-cloud" plugin, and those builders into another one (unfortunately we already have docker-build-step-plugin. Another one would add to the confusion). Docker plugin would then just act as some agregator plugin, maybe only offer some global configuration for Registry / DockerHost
 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr04rUG_93UkFQv3vwqMVxvnWfE8RFUaQ-C%2B3jRy%2BvAWKw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzn3muoX9PFCP%3D93MUY1YbCUdwofCLnv0uEYv%3D1viCTs2A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.