XTrigger-Lib needs maintenance/release

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

XTrigger-Lib needs maintenance/release

Tony Noble
I realise this isn't a plugin as such, so not sure how the process would work.

A number of trigger plugins, mine included (urltrigger) rely on xtrigger-lib to perform the core job handling and cron scheduling.  From what I can see, Gregory Boissinot used to maintain this, along with the dependent plugins, but I'm guessing he stepped back from them all at the same time.

At the moment, a number of issues within xtrigger-lib prevent the dependent plugins from being pipeline-compliant.  Proposed fixes for them have been merged by @oleg-nenashev , but no release has been performed, so they're not specifically useable.

I guess the questions is - how do I go about getting a release created?  I'm happy to take the responsibility on myself, if that's what's required, but as mentioned above, I'm not sure how the process would work for a lib rather than a plugin.

Tony

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9EAKt906QXUPjjZAc%2B-TAu4-wc5FC%2BDutqArEm1eb2tCg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Oleg Nenashev
FTR, there was a thread about the next steps for XTrigger lib: https://groups.google.com/forum/#!searchin/jenkinsci-dev/XTrigger%7Csort:date/jenkinsci-dev/voKBrqz7V_o/rCP5ysYZBwAJ
AFAICT, we still need to get a release, and ownership has not been fully transferred to anyone.

Tony, if you are fine with that, we can just co-maintain the library for now.
In my case I would rather want to help to get it over the line and to help with further releases if needed, I have no time to really "maintain" the component

WDYT?


On Thursday, July 11, 2019 at 11:48:45 AM UTC+2, Tony Noble wrote:
I realise this isn't a plugin as such, so not sure how the process would work.

A number of trigger plugins, mine included (urltrigger) rely on xtrigger-lib to perform the core job handling and cron scheduling.  From what I can see, Gregory Boissinot used to maintain this, along with the dependent plugins, but I'm guessing he stepped back from them all at the same time.

At the moment, a number of issues within xtrigger-lib prevent the dependent plugins from being pipeline-compliant.  Proposed fixes for them have been merged by @oleg-nenashev , but no release has been performed, so they're not specifically useable.

I guess the questions is - how do I go about getting a release created?  I'm happy to take the responsibility on myself, if that's what's required, but as mentioned above, I'm not sure how the process would work for a lib rather than a plugin.

Tony

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/edb112a3-84f7-4acf-8581-ccff5caf4cdf%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble
Hi @oleg-nenashev,

That sounds ideal.  I do remember the thread now, but have to admit - I'm very much of the 'just keep it working' approach for the moment, until I get my head around how to create plugins that are essentially subclasses of other plugins (which is what would need to happen if xtrigger was migrated to be a plugin).  And if it's even possible to do all this without breaking existing user configuration.

I can raise the PR for repository permissions - what needs to happen for commit access to the repo?

Tony

On Thu, Jul 11, 2019 at 10:53 AM Oleg Nenashev <[hidden email]> wrote:
FTR, there was a thread about the next steps for XTrigger lib: https://groups.google.com/forum/#!searchin/jenkinsci-dev/XTrigger%7Csort:date/jenkinsci-dev/voKBrqz7V_o/rCP5ysYZBwAJ
AFAICT, we still need to get a release, and ownership has not been fully transferred to anyone.

Tony, if you are fine with that, we can just co-maintain the library for now.
In my case I would rather want to help to get it over the line and to help with further releases if needed, I have no time to really "maintain" the component

WDYT?


On Thursday, July 11, 2019 at 11:48:45 AM UTC+2, Tony Noble wrote:
I realise this isn't a plugin as such, so not sure how the process would work.

A number of trigger plugins, mine included (urltrigger) rely on xtrigger-lib to perform the core job handling and cron scheduling.  From what I can see, Gregory Boissinot used to maintain this, along with the dependent plugins, but I'm guessing he stepped back from them all at the same time.

At the moment, a number of issues within xtrigger-lib prevent the dependent plugins from being pipeline-compliant.  Proposed fixes for them have been merged by @oleg-nenashev , but no release has been performed, so they're not specifically useable.

I guess the questions is - how do I go about getting a release created?  I'm happy to take the responsibility on myself, if that's what's required, but as mentioned above, I'm not sure how the process would work for a lib rather than a plugin.

Tony

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/edb112a3-84f7-4acf-8581-ccff5caf4cdf%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9E93r_Z0k--JZWnx-wqb4q%3Dzozp_5qqi83SfZ3EKOnDHA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Jesse Glick-4
On Thu, Jul 11, 2019 at 6:14 AM Tony Noble <[hidden email]> wrote:
> how to create plugins that are essentially subclasses of other plugins (which is what would need to happen if xtrigger was migrated to be a plugin)

Completely routine; you just declare a Maven dependency and you are
done. Certainly less exotic and trouble-prone than the current design.

https://jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/

> if it's even possible to do all this without breaking existing user configuration.

Assuming Java package names are left untouched, there should be no
effect on user settings.

At any rate,

> I'm not sure how the process would work for a lib rather than a plugin.

The release process for the library is identical to that for a plugin:

mvn release:{prepare,perform}

The additional step in the current design is that you then need to go
to all the plugins using the library, update their dependency, and
release them too. If we switched the library to a plugin, it would
suffice to just release it—anyone accepting that update would get the
new behavior for all the feature plugins, since these would no longer
be physically bundling the library.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3kSjVPmxE%3DY42Mvari_pNtMHOCR3hKDDLGAoqnm8R8BQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble
On Thu, Jul 11, 2019 at 3:17 PM Jesse Glick <[hidden email]> wrote:
Completely routine; you just declare a Maven dependency and you are
done. Certainly less exotic and trouble-prone than the current design.

https://jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/

Thanks.  That gives me somethign to get stuck in to. 

The release process for the library is identical to that for a plugin:

mvn release:{prepare,perform}


Apologies - I meant the process of being added as a maintainer :0)  Thankfully the day job means I'm pretty comfortable with maven releases.

The additional step in the current design is that you then need to go
to all the plugins using the library, update their dependency, and
release them too. If we switched the library to a plugin, it would
suffice to just release it—anyone accepting that update would get the
new behavior for all the feature plugins, since these would no longer
be physically bundling the library.

True, but then if I read that correctly, any breaking change of the xtrigger plugin would require all dependant plugins to be updated and a co-ordinated release organised, rather than the current system where the dependent plugins simply avoid bumping the version of xtigger until they're ready?  The issue I see there is that (from what I can see) all the dependent plugins, or at least a lot of them, were maintained by Gregory and are now effectively unmaintained...

Admittedly, that's a problem to deal with as and when we get to the migration and I realise that the answer will probably be "don't make any breaking changes" :0)

Tony

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9GWZG6oN0XyP17uhE%3DyWXAZtEZPpdqnZ%2Bk%3DesM1n6B%2BMA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Jesse Glick-4
On Thu, Jul 11, 2019 at 10:27 AM Tony Noble <[hidden email]> wrote:
> any breaking change of the xtrigger plugin would require all dependant plugins to be updated and a co-ordinated release organised

Yes…so do not make breaking changes.

> The issue I see there is that (from what I can see) all the dependent plugins, or at least a lot of them, were maintained by Gregory and are now effectively unmaintained

I would advise anyone taking over as owner of part of this to ask to
be made owner of all of them. (Does not mean other interested parties
cannot contribute or even be primarily responsible for substantive
changes—just means that you have permissions to make changes to the
whole set of things when you need to.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1N9RfJVZt%3Dtf%2BZtgA%3DHcL%2BdcFjjWxFrJjuVoxESqny%2Bg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble
Pull request submitted for release permissions: https://github.com/jenkins-infra/repository-permissions-updater/pull/1216

Could I also be give access to the github repo for xtrigger-lib, please?  

GitHub id: TonyNoble
Jenkins id: stealthdj

I'll look at what other plugins depend on xtrigger and submit a separate request for those.  Judging by the issues I've discovered with this update and previous conversations, I'm guessing that envinject may well also need to be included.

Thanks,

Tony

On Thu, Jul 11, 2019 at 7:00 PM Jesse Glick <[hidden email]> wrote:
On Thu, Jul 11, 2019 at 10:27 AM Tony Noble <[hidden email]> wrote:
> any breaking change of the xtrigger plugin would require all dependant plugins to be updated and a co-ordinated release organised

Yes…so do not make breaking changes.

> The issue I see there is that (from what I can see) all the dependent plugins, or at least a lot of them, were maintained by Gregory and are now effectively unmaintained

I would advise anyone taking over as owner of part of this to ask to
be made owner of all of them. (Does not mean other interested parties
cannot contribute or even be primarily responsible for substantive
changes—just means that you have permissions to make changes to the
whole set of things when you need to.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1N9RfJVZt%3Dtf%2BZtgA%3DHcL%2BdcFjjWxFrJjuVoxESqny%2Bg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9HswQKOCBePqePtUFK2oN5WUA333FRh02bwtQYWCGGHSA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble
@jglick , @oleg-nenashev

Using xtrigger-plugin as a guide, I'd suggest that the following should be grouped together as previously owned by Gregory.  As such, please could I be added as maintainer on github to:
I note that EnvInject has since been converted to a plugin - should I include this, or are you happy with the current setup for it?

Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?

Thanks,

Tony

(GitHub id: TonyNoble , Jenkins id: StealthDJ)


On Thu, Jul 11, 2019 at 11:48 PM Tony Noble <[hidden email]> wrote:
Pull request submitted for release permissions: https://github.com/jenkins-infra/repository-permissions-updater/pull/1216

Could I also be give access to the github repo for xtrigger-lib, please?  

GitHub id: TonyNoble
Jenkins id: stealthdj

I'll look at what other plugins depend on xtrigger and submit a separate request for those.  Judging by the issues I've discovered with this update and previous conversations, I'm guessing that envinject may well also need to be included.

Thanks,

Tony

On Thu, Jul 11, 2019 at 7:00 PM Jesse Glick <[hidden email]> wrote:
On Thu, Jul 11, 2019 at 10:27 AM Tony Noble <[hidden email]> wrote:
> any breaking change of the xtrigger plugin would require all dependant plugins to be updated and a co-ordinated release organised

Yes…so do not make breaking changes.

> The issue I see there is that (from what I can see) all the dependent plugins, or at least a lot of them, were maintained by Gregory and are now effectively unmaintained

I would advise anyone taking over as owner of part of this to ask to
be made owner of all of them. (Does not mean other interested parties
cannot contribute or even be primarily responsible for substantive
changes—just means that you have permissions to make changes to the
whole set of things when you need to.)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1N9RfJVZt%3Dtf%2BZtgA%3DHcL%2BdcFjjWxFrJjuVoxESqny%2Bg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9G1Wy0MMMwZCidQ8E_SU9AzXovf1tLdSEL_HJpATKsvhA%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Daniel Beck


> On 20. Jul 2019, at 14:52, Tony Noble <[hidden email]> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Oleg Nenashev
My plan was to keep EnvInject Lib as a temporary lib until all plugins and "libs" switch to EnvInject API. Then I would have moved the code and removed the library repository. It was at the time of a Pipeline compatibility effort 4 years ago. But we have not been able to rework all Geegory's plugins at that time, switched to other tasks.

If you rework XTrigger Lib to a plugin, please use EnvInject API Plugin as a dependency.

BR, Oleg

On Sat, Jul 20, 2019, 19:54 Daniel Beck <[hidden email]> wrote:


> On 20. Jul 2019, at 14:52, Tony Noble <[hidden email]> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble
Okay, so modifications:

- No need to add me as maintainer for envinject-lib
- XTrigger-lib plugin replacement will be named XTrigger-api-plugin

On that basis, if someone could add me as maintainer for the rest, it'd be much appreciated.

Tony



On Sat, Jul 20, 2019 at 7:15 PM Oleg Nenashev <[hidden email]> wrote:
My plan was to keep EnvInject Lib as a temporary lib until all plugins and "libs" switch to EnvInject API. Then I would have moved the code and removed the library repository. It was at the time of a Pipeline compatibility effort 4 years ago. But we have not been able to rework all Geegory's plugins at that time, switched to other tasks.

If you rework XTrigger Lib to a plugin, please use EnvInject API Plugin as a dependency.

BR, Oleg

On Sat, Jul 20, 2019, 19:54 Daniel Beck <[hidden email]> wrote:


> On 20. Jul 2019, at 14:52, Tony Noble <[hidden email]> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9F7EtEqbZCX%3Do6xNx--Yg4PU0QodxmO1KE3uCN%3DmSjK9g%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Oleg Nenashev
Hi Tony,

I have granted you write access and made you a default assignee in the components.
If you decide  to become a maintainer of the EnvInject stuff, I will be happy to grant your permissions as well.

Some notes:
  • To release the components, you will need to create a pull request to https://github.com/jenkins-infra/repository-permissions-updater
  • ColMelvin has contributed a lot of patches which have not been released yet. IIRC I reviewed them 1 year ago, but nobody took ownership at that point. Some area for collaboration there, maybe
  • For plugin you plan to maintain in longer term, it might make sense to use Release Drafter for changelogs (docs)
Best regards,
Oleg

On Saturday, July 20, 2019 at 9:30:49 PM UTC+2, Tony Noble wrote:
Okay, so modifications:

- No need to add me as maintainer for envinject-lib
- XTrigger-lib plugin replacement will be named XTrigger-api-plugin

On that basis, if someone could add me as maintainer for the rest, it'd be much appreciated.

Tony



On Sat, Jul 20, 2019 at 7:15 PM Oleg Nenashev <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="eGaXxBeKDwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">o.v.n...@...> wrote:
My plan was to keep EnvInject Lib as a temporary lib until all plugins and "libs" switch to EnvInject API. Then I would have moved the code and removed the library repository. It was at the time of a Pipeline compatibility effort 4 years ago. But we have not been able to rework all Geegory's plugins at that time, switched to other tasks.

If you rework XTrigger Lib to a plugin, please use EnvInject API Plugin as a dependency.

BR, Oleg

On Sat, Jul 20, 2019, 19:54 Daniel Beck <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="eGaXxBeKDwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">m...@...> wrote:


> On 20. Jul 2019, at 14:52, Tony Noble <<a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="eGaXxBeKDwAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">tony...@...> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit <a href="https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe&#39;;return true;">https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to <a href="javascript:" rel="nofollow" target="_blank" gdf-obfuscated-mailto="eGaXxBeKDwAJ" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="eGaXxBeKDwAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">jenkin...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6ea8aa69-4713-43af-ae1f-181dc37e9000%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble

On Sun, Jul 21, 2019 at 9:50 AM Oleg Nenashev <[hidden email]> wrote:
Hi Tony,

I have granted you write access and made you a default assignee in the components.
If you decide  to become a maintainer of the EnvInject stuff, I will be happy to grant your permissions as well.

Some notes:
  • To release the components, you will need to create a pull request to https://github.com/jenkins-infra/repository-permissions-updater
  • ColMelvin has contributed a lot of patches which have not been released yet. IIRC I reviewed them 1 year ago, but nobody took ownership at that point. Some area for collaboration there, maybe
  • For plugin you plan to maintain in longer term, it might make sense to use Release Drafter for changelogs (docs)
Best regards,
Oleg

On Saturday, July 20, 2019 at 9:30:49 PM UTC+2, Tony Noble wrote:
Okay, so modifications:

- No need to add me as maintainer for envinject-lib
- XTrigger-lib plugin replacement will be named XTrigger-api-plugin

On that basis, if someone could add me as maintainer for the rest, it'd be much appreciated.

Tony



On Sat, Jul 20, 2019 at 7:15 PM Oleg Nenashev <[hidden email]> wrote:
My plan was to keep EnvInject Lib as a temporary lib until all plugins and "libs" switch to EnvInject API. Then I would have moved the code and removed the library repository. It was at the time of a Pipeline compatibility effort 4 years ago. But we have not been able to rework all Geegory's plugins at that time, switched to other tasks.

If you rework XTrigger Lib to a plugin, please use EnvInject API Plugin as a dependency.

BR, Oleg

On Sat, Jul 20, 2019, 19:54 Daniel Beck <[hidden email]> wrote:


> On 20. Jul 2019, at 14:52, Tony Noble <[hidden email]> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6ea8aa69-4713-43af-ae1f-181dc37e9000%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9G7ChHD3apzADbOjYpkNDo1bSh7zf5RSiSQTUV9NcqPJg%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Tony Noble
Pull request looks to have been approved, but not applied - can anyone assist?

Cheers,

Tony

On Sun, Jul 21, 2019 at 1:35 PM Tony Noble <[hidden email]> wrote:

On Sun, Jul 21, 2019 at 9:50 AM Oleg Nenashev <[hidden email]> wrote:
Hi Tony,

I have granted you write access and made you a default assignee in the components.
If you decide  to become a maintainer of the EnvInject stuff, I will be happy to grant your permissions as well.

Some notes:
  • To release the components, you will need to create a pull request to https://github.com/jenkins-infra/repository-permissions-updater
  • ColMelvin has contributed a lot of patches which have not been released yet. IIRC I reviewed them 1 year ago, but nobody took ownership at that point. Some area for collaboration there, maybe
  • For plugin you plan to maintain in longer term, it might make sense to use Release Drafter for changelogs (docs)
Best regards,
Oleg

On Saturday, July 20, 2019 at 9:30:49 PM UTC+2, Tony Noble wrote:
Okay, so modifications:

- No need to add me as maintainer for envinject-lib
- XTrigger-lib plugin replacement will be named XTrigger-api-plugin

On that basis, if someone could add me as maintainer for the rest, it'd be much appreciated.

Tony



On Sat, Jul 20, 2019 at 7:15 PM Oleg Nenashev <[hidden email]> wrote:
My plan was to keep EnvInject Lib as a temporary lib until all plugins and "libs" switch to EnvInject API. Then I would have moved the code and removed the library repository. It was at the time of a Pipeline compatibility effort 4 years ago. But we have not been able to rework all Geegory's plugins at that time, switched to other tasks.

If you rework XTrigger Lib to a plugin, please use EnvInject API Plugin as a dependency.

BR, Oleg

On Sat, Jul 20, 2019, 19:54 Daniel Beck <[hidden email]> wrote:


> On 20. Jul 2019, at 14:52, Tony Noble <[hidden email]> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6ea8aa69-4713-43af-ae1f-181dc37e9000%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9HA8ETqBpxbRODcsgZAEEkDPGQ8FRxe8d2hb3EHTNzGOQ%40mail.gmail.com.
Reply | Threaded
Open this post in threaded view
|

Re: XTrigger-Lib needs maintenance/release

Oleg Nenashev
done. Was waiting for more confirmations, but it got stalled

On Fri, Jul 26, 2019 at 2:37 PM Tony Noble <[hidden email]> wrote:
Pull request looks to have been approved, but not applied - can anyone assist?

Cheers,

Tony

On Sun, Jul 21, 2019 at 1:35 PM Tony Noble <[hidden email]> wrote:

On Sun, Jul 21, 2019 at 9:50 AM Oleg Nenashev <[hidden email]> wrote:
Hi Tony,

I have granted you write access and made you a default assignee in the components.
If you decide  to become a maintainer of the EnvInject stuff, I will be happy to grant your permissions as well.

Some notes:
  • To release the components, you will need to create a pull request to https://github.com/jenkins-infra/repository-permissions-updater
  • ColMelvin has contributed a lot of patches which have not been released yet. IIRC I reviewed them 1 year ago, but nobody took ownership at that point. Some area for collaboration there, maybe
  • For plugin you plan to maintain in longer term, it might make sense to use Release Drafter for changelogs (docs)
Best regards,
Oleg

On Saturday, July 20, 2019 at 9:30:49 PM UTC+2, Tony Noble wrote:
Okay, so modifications:

- No need to add me as maintainer for envinject-lib
- XTrigger-lib plugin replacement will be named XTrigger-api-plugin

On that basis, if someone could add me as maintainer for the rest, it'd be much appreciated.

Tony



On Sat, Jul 20, 2019 at 7:15 PM Oleg Nenashev <[hidden email]> wrote:
My plan was to keep EnvInject Lib as a temporary lib until all plugins and "libs" switch to EnvInject API. Then I would have moved the code and removed the library repository. It was at the time of a Pipeline compatibility effort 4 years ago. But we have not been able to rework all Geegory's plugins at that time, switched to other tasks.

If you rework XTrigger Lib to a plugin, please use EnvInject API Plugin as a dependency.

BR, Oleg

On Sat, Jul 20, 2019, 19:54 Daniel Beck <[hidden email]> wrote:


> On 20. Jul 2019, at 14:52, Tony Noble <[hidden email]> wrote:
>
> Another point to note - given that the goal for xtrigger-lib is to convert to a plugin, the natural name for it would be xtrigger-plugin.  But that's obviously taken as noted above - rather than go off on the wrong track, would 'xtrigger-base-plugin' seem reasonable?
>

It's customary to name it whatever-api in Jenkins. envinject-lib is provided by the plugin 'envinject-api', there's branch-api and scm-api, etc.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6ea8aa69-4713-43af-ae1f-181dc37e9000%40googlegroups.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9HA8ETqBpxbRODcsgZAEEkDPGQ8FRxe8d2hb3EHTNzGOQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBO%2By9BZ6pov64EAC%2BShoU46kTY_7Y1z%3DJ4Jn2T%2Bcq0vQ%40mail.gmail.com.