gitblamer skips file annotation with relative path

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

gitblamer skips file annotation with relative path

Mathieu Zhang
I have the following workspace structure:

- ${WORKSPACE}/git-checkout
- ${WORKSPACE}/artifacts

The codes are build with (from WORKSPACE)

make -C git-checkout ARTIFACTS_DIR=${WORKSPACE}/artifacts

which would write output files to ${WORKSPACE}/artifacts, including pylint output, which contains lines like this

src/updates/update.py:028: [E0611(no-name-in-module), ] No name 'updates' in module 'utils'


gitblamer is unable the generate blames from this annotation, with series of warnings like this:

<Git Blamer> Using GitBlamer to create author and commit information for all warnings.
<Git Blamer> GIT_COMMIT=c636547ad11d989ef8f984591468cc00c46fb345, workspace=/var/jenkins/build/workspace/project-builder/git-checkout
<Git Blamer> Skipping non-workspace file /var/jenkins/build/workspace/project-builder/git-checkout/src/updates/update.py (workspace = /var/jenkins/build/workspace/project-builder/git-checkout, absolute = /src/updates/update.py.
<Git Blamer> Skipping file src/updates/update.py, no result found.

Even though the gitblamer's workspace variable correctly identified the git path, it does not appear to be able to deal with relative path in the file annotation correctly.  Is this an issue with gitblamer? Or is it expected that the file line annotation uses absolute path?

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/06c568fa-87a9-4da1-8959-cb30d25e75fe%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: gitblamer skips file annotation with relative path

Ulli Hafner
This seems to be a bug: your relative path is converted to an absolute path by mistake. Can you please file an issue (don’t forget to add the affected parser).

Am 28.11.2017 um 23:12 schrieb Mathieu Zhang <[hidden email]>:

I have the following workspace structure:

- ${WORKSPACE}/git-checkout
- ${WORKSPACE}/artifacts

The codes are build with (from WORKSPACE)

make -C git-checkout ARTIFACTS_DIR=${WORKSPACE}/artifacts

which would write output files to ${WORKSPACE}/artifacts, including pylint output, which contains lines like this

src/updates/update.py:028: [E0611(no-name-in-module), ] No name 'updates' in module 'utils'


gitblamer is unable the generate blames from this annotation, with series of warnings like this:

<Git Blamer> Using GitBlamer to create author and commit information for all warnings.
<Git Blamer> GIT_COMMIT=c636547ad11d989ef8f984591468cc00c46fb345, workspace=/var/jenkins/build/workspace/project-builder/git-checkout
<Git Blamer> Skipping non-workspace file /var/jenkins/build/workspace/project-builder/git-checkout/src/updates/update.py (workspace = /var/jenkins/build/workspace/project-builder/git-checkout, absolute = /src/updates/update.py.
<Git Blamer> Skipping file src/updates/update.py, no result found.

Even though the gitblamer's workspace variable correctly identified the git path, it does not appear to be able to deal with relative path in the file annotation correctly.  Is this an issue with gitblamer? Or is it expected that the file line annotation uses absolute path?

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/06c568fa-87a9-4da1-8959-cb30d25e75fe%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/4C4A2722-A6FD-49FA-8A3E-80A972797168%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

signature.asc (540 bytes) Download Attachment