Quantcast

pull request for JENKINS-11887 Support Trac+Git as repository browser

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

pull request for JENKINS-11887 Support Trac+Git as repository browser

Gerd Zanker
Hello trac plugin maintainers,

I want to ask you to review my pull request https://github.com/jenkinsci/trac-plugin/pull/1
and give feedback? I use my branch for three weeks without any issues
and it would be nice to get my extension via an updated trac plugin
release from the jenkins site.

Thanks,
Gerd
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: pull request for JENKINS-11887 Support Trac+Git as repository browser

jieryn
Greetings,

On Mon, Jan 23, 2012 at 1:59 PM, Gerd Zanker <[hidden email]> wrote:
> Hello trac plugin maintainers,

There really isn't any dedicated maintainer for this plugin.

> I want to ask you to review my pull request https://github.com/jenkinsci/trac-plugin/pull/1
> and give feedback? I use my branch for three weeks without any issues
> and it would be nice to get my extension via an updated trac plugin
> release from the jenkins site.

Would you like to become a committer on this project and take over as
active maintainer? Then you can apply the pull request, and perform
the release.

-Jesse

--
There are 10 types of people in this world, those
that can read binary and those that can not.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: pull request for JENKINS-11887 Support Trac+Git as repository browser

Gerd Zanker
Hello Jesse,

On 23 Jan., 20:10, Jesse Farinacci <[hidden email]> wrote:
> Would you like to become a committer on this project and take over as
> active maintainer? Then you can apply the pull request, and perform
> the release.

I have a big interest to see my changes released and I can also spend
some time to take care of the other open trac plugin issues. Is there
any committer manual available about how releases are done? Or any
other guidance to step into this new world of committers?

I'm confident about my java changes of [JENKINS-11887], but I also
introduced a new dependency from trac to the git plugin. Do you see
any side effect if this changed dependency is released?

Gerd
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: pull request for JENKINS-11887 Support Trac+Git as repository browser

jieryn
Greetings,

On Tue, Jan 24, 2012 at 2:46 PM, Gerd Zanker <[hidden email]> wrote:
>
> I have a big interest to see my changes released and I can also spend
> some time to take care of the other open trac plugin issues. Is there
> any committer manual available about how releases are done? Or any
> other guidance to step into this new world of committers?

That's great! Please provide your GitHub user id and we'll get you all
set up as a committer. As far as guidance for plugin maintainer, I
would like for someone to correct me but, I think not much:

https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins
https://wiki.jenkins-ci.org/display/JENKINS/Dev+Good+Practice
https://wiki.jenkins-ci.org/display/JENKINS/Plugin+Release+Tips
$ mvn -B release:prepare release:perform

> I'm confident about my java changes of [JENKINS-11887], but I also
> introduced a new dependency from trac to the git plugin. Do you see
> any side effect if this changed dependency is released?

I think the way Jenkins handles ClassLoaders for plugins is a bit of
black magic. Perhaps it is my inexperience in this regard, but I think
a real problem that we're already seeing, and will likely see more of
in the future, is when plugins have optional dependencies on other
plugins. And shared dependencies with different versions (heck, even
same versions is causing plugin/deployment bloat) is also a bit weird.

I don't think that depending on the git plugin is a big deal, there
probably is an elegant (from the user perspective) way of handling
this as an optional dependency and catching UnsatisfiedLinkError for
reduced function, but I am not familiar with it...

-Jesse

--
There are 10 types of people in this world, those
that can read binary and those that can not.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: pull request for JENKINS-11887 Support Trac+Git as repository browser

Gerd Zanker
Hello Jesse,

> That's great! Please provide your GitHub user id and we'll get you all
> set up as a committer.
My githup user id is "GerdZanker".

> As far as guidance for plugin maintainer,
> I would like for someone to correct me but, I think not much:

Thanks for the links - I found nearly nothing when I searched for
"committer".

Yours,
Gerd
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: pull request for JENKINS-11887 Support Trac+Git as repository browser

jieryn
Greetings,

On Sun, Jan 29, 2012 at 11:23 AM, Gerd Zanker
<[hidden email]> wrote:
> My githup user id is "GerdZanker".

You're all set up, welcome aboard.

-Jesse

--
There are 10 types of people in this world, those
that can read binary and those that can not.
Loading...